File perl-file_path_rmtree_chmod_again.diff of Package perl

Overview Repositories Revisions Requests Users Attributes Meta

File perl-file_path_rmtree_chmod_again.diff of Package perl (Revision 76bf86c4fbc7b6c33bfbfd60c9aa3128)

Currently displaying revision 76bf86c4fbc7b6c33bfbfd60c9aa3128 , Show latest

--- lib/File/Path.pm.orig
+++ lib/File/Path.pm
@@ -316,10 +316,8 @@ sub _rmtree {
                     print "skipped $root\n" if $arg->{verbose};
                     next ROOT_DIR;
                 }
-                if (!chmod $perm | 0700, $root) {
-                    if ($Force_Writeable) {
-                        _error($arg, "cannot make directory writeable", $canon);
-                    }
+                if ($Force_Writeable && !chmod $perm | 0700, $root) {
+                    _error($arg, "cannot make directory writeable", $canon);
                 }
                 print "rmdir $root\n" if $arg->{verbose};
                 if (rmdir $root) {
@@ -328,7 +326,7 @@ sub _rmtree {
                 }
                 else {
                     _error($arg, "cannot remove directory", $canon);
-                    if (!chmod($perm, ($Is_VMS ? VMS::Filespec::fileify($root) : $root))
+                    if ($Force_Writeable && !chmod($perm, ($Is_VMS ? VMS::Filespec::fileify($root) : $root))
                     ) {
                         _error($arg, sprintf("cannot restore permissions to 0%o",$perm), $canon);
                     }

Places

File perl-file_path_rmtree_chmod_again.diff of Package perl (Revision 76bf86c4fbc7b6c33bfbfd60c9aa3128)

Places