File trackballs-1.1.4-codecleanup.diff of Package trackballs

Index: src/font.cc
===================================================================
--- src/font.cc.orig	2005-11-22 23:11:48.000000000 +0100
+++ src/font.cc	2010-03-07 17:24:16.000000000 +0100
@@ -207,6 +207,7 @@ int Font::figureFontInfo(void *pixels, i
   this->char_sizes[5*CHAR_WNB+2]=0;
   this->char_sizes[4*CHAR_WNB+14]=0;
   */
+  return 1;
 }
 
 int Font::addText(int font, const char *text, int x, int y, float sx, float sy, double delay,
@@ -806,6 +807,7 @@ int Font::l_drawSimpleText(const char *t
   glEnd();
 
   Leave2DMode();
+  return 0;
 }
 
 int Font::l_drawRightSimpleText(const char *text, int x, int y, float sx, float sy, float r, float g, float b, float a) {
@@ -849,6 +851,7 @@ int Font::l_drawSimpleText3D(const char
   }
 
   glEnd();
+  return 0;
 }
 
 
Index: src/glHelp.cc
===================================================================
--- src/glHelp.cc.orig	2007-04-07 15:15:09.000000000 +0200
+++ src/glHelp.cc	2010-03-07 17:24:32.000000000 +0100
@@ -282,7 +282,7 @@ int createSnapshot()
   /* allocate buffer */
   if ((buffer = (unsigned char*)malloc(sizeof(unsigned char)*screenWidth*screenHeight*3)) == NULL)
     {
-    fprintf(stderr, _("Warning: cannot allocate %d bytes for snapshot. Aborting.\n"), sizeof(unsigned char)*screenWidth*screenHeight*3);
+    fprintf(stderr, _("Warning: cannot allocate %lu bytes for snapshot. Aborting.\n"), sizeof(unsigned char)*screenWidth*screenHeight*3);
     return(0);
     }
 
@@ -336,6 +336,7 @@ int createSnapshot()
   /* freed everything */
   fclose(f);
   free(buffer);
+  return 0;
 }
 
 
Index: src/guile.cc
===================================================================
--- src/guile.cc.orig	2007-05-25 16:22:16.000000000 +0200
+++ src/guile.cc	2010-03-07 17:24:16.000000000 +0100
@@ -1121,11 +1121,11 @@ SCM_DEFINE (difficulty, "difficulty", 0,
 
 /*********** use-grid ************/
 SCM_DEFINE (use_grid, "use-grid", 1, 0, 0, (SCM v), "Turns the grid on/off")
-{ Game::current->useGrid=SCM_FALSEP(v)?0:1; }
+{ Game::current->useGrid=SCM_FALSEP(v)?0:1; return 0; }
 
 /*********** map-is-transparent ************/
 SCM_DEFINE (map_is_transparent, "map-is-transparent", 1, 0, 0, (SCM v), "Turns on/off transparency rendering of map.")
-{ Game::current->map->isTransparent=SCM_FALSEP(v)?0:1; }
+{ Game::current->map->isTransparent=SCM_FALSEP(v)?0:1; return 0; }
 
 /*********** jump ************/
 SCM_DEFINE (jump, "jump", 1, 0, 0, (SCM v), "Scales maximum jump height of player.")
@@ -1134,6 +1134,7 @@ SCM_DEFINE (jump, "jump", 1, 0, 0, (SCM
   SCM_ASSERT(SCM_NUMBERP(v),v,SCM_ARG1,FUNC_NAME);
   if(Game::current)
 	Game::current->jumpFactor=scm_num2dbl(v,FUNC_NAME);
+  return 0;
 }
 #undef FUNC_NAME
 
@@ -1144,6 +1145,7 @@ SCM_DEFINE (scale_oxygen, "scale-oxygen"
   SCM_ASSERT(SCM_NUMBERP(v),v,SCM_ARG1,FUNC_NAME);
   if(Game::current)
 	Game::current->oxygenFactor=scm_num2dbl(v,FUNC_NAME);
+  return 0;
 }
 #undef FUNC_NAME
 
@@ -1348,6 +1350,7 @@ SCM_DEFINE (camera_angle,"camera-angle",
   SCM_ASSERT(SCM_NUMBERP(z),z,SCM_ARG2,FUNC_NAME);
   ((MainMode*)GameMode::current)->wantedXYAngle = scm_num2dbl(xy,FUNC_NAME);
   ((MainMode*)GameMode::current)->wantedZAngle = scm_num2dbl(z,FUNC_NAME);
+  return 0;
 }
 #undef FUNC_NAME
 
@@ -1358,6 +1361,7 @@ SCM_DEFINE (restart_time,"restart-time",
 { 
   SCM_ASSERT(SCM_NUMBERP(t),t,SCM_ARG1,FUNC_NAME);
   Game::current->player1->timeOnDeath=scm_num2dbl(t,FUNC_NAME);
+  return 0;
 }
 #undef FUNC_NAME
 
Index: src/image.cc
===================================================================
--- src/image.cc.orig	2005-11-22 23:11:48.000000000 +0100
+++ src/image.cc	2010-03-07 17:24:16.000000000 +0100
@@ -59,7 +59,7 @@ static Image *ImageOpen(char *fileName)
   image = (Image *) malloc(sizeof(Image));
   if(image == NULL) 
   {
-    fprintf(stderr, "Cannot allocate '%d' bytes.\n", sizeof(Image));
+    fprintf(stderr, "Cannot allocate '%z' bytes.\n", sizeof(Image));
     return(NULL);
   }
   if((image->file = fopen(fileName, "rb")) == NULL) 
@@ -230,7 +230,7 @@ IMAGE *ImageLoad(char *fileName)
   final = (IMAGE *) malloc(sizeof(IMAGE));
   if(final == NULL) 
   {
-    fprintf(stderr, "Cannot allocate '%d' bytes.\n", sizeof(IMAGE));
+    fprintf(stderr, "Cannot allocate '%z' bytes.\n", sizeof(IMAGE));
     ImageClose(image);
     return(NULL);
   }
@@ -253,7 +253,7 @@ IMAGE *ImageLoad(char *fileName)
   {
     ImageClose(image);
     free(final);
-    fprintf(stderr, "Cannot allocate '%d' bytes.\n", sx * image->sizeY * sizeof(unsigned int));
+    fprintf(stderr, "Cannot allocate '%z' bytes.\n", sx * image->sizeY * sizeof(unsigned int));
     return(NULL);
   }
 
@@ -283,7 +283,7 @@ void read_2d_image_rgb(char *image, unsi
   *rbuffer = (unsigned char*)malloc(sizeof(unsigned char)*base_image->sizeX*base_image->sizeY*4);
   if (*rbuffer == NULL)
   {
-    fprintf(stderr, "Cannot allocate '%d' bytes for image '%s'\n", sizeof(unsigned char)*base_image->sizeX*base_image->sizeY*4, image);
+    fprintf(stderr, "Cannot allocate '%z' bytes for image '%s'\n", sizeof(unsigned char)*base_image->sizeX*base_image->sizeY*4, image);
     /* Free the image */
     free(base_image->data);
     free(base_image);
Index: src/player.cc
===================================================================
--- src/player.cc.orig	2007-05-25 11:42:39.000000000 +0200
+++ src/player.cc	2010-03-07 17:24:16.000000000 +0100
@@ -75,7 +75,7 @@ void Player::draw() {
   Ball::draw();
 }
 void Player::tick(Real t) {
-  double dx,dy;
+  double dx = 0.0,dy = 0.0;
   int superAccelerate=0;
   static time_t lastTick=0;
 
@@ -370,4 +370,5 @@ Boolean Player::crash(Real speed) {
   double espeed=modTimeLeft[MOD_GLASS] ? (1.5*speed) / crashTolerance : speed / crashTolerance;
   setHealth(1.0-espeed);
   this->Ball::crash(speed);
+  return true;
 }