File ekanalyzer_fix_wrong_type_comparison.patch of Package ipmitool

Overview Repositories Revisions Requests Users Attributes Meta

File ekanalyzer_fix_wrong_type_comparison.patch of Package ipmitool

Fix typo, fix wrong pointer usage

I expect this is what the author wanted to do.
Testing the board_length pointer to be !NULL makes no sense at this place,
it should have been done earlier or a segfault could already happen because
of the (*board_length)--; usage some lines above.

This fixes a compiler warning and likley fixes a real bug.
Additional reference:
https://bugzilla.novell.com/show_bug.cgi?id=439490

Signed-off-by: Thomas Renninger <trenn@suse.de>

---
 lib/ipmi_ekanalyzer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: ipmitool-1.8.11/lib/ipmi_ekanalyzer.c
===================================================================
--- ipmitool-1.8.11.orig/lib/ipmi_ekanalyzer.c
+++ ipmitool-1.8.11/lib/ipmi_ekanalyzer.c
@@ -2624,12 +2624,12 @@ ipmi_ek_display_board_info_area( FILE *
    if ( !feof(input_file) ){
       unsigned int size_board = 0;
 
-      /*Bit 5:0 of Board Mfg type represent legnth*/
+      /*Bit 5:0 of Board Mfg type represent length*/
       size_board = (len & 0x3f);
       if (size_board > 0){
          if ( strncmp( board_type, "Custom", 6 ) == 0 ){
             #define NO_MORE_INFO_FIELD         0xc1
-            while ( !feof(input_file) && (board_length > 0) ){
+            while ( !feof(input_file) && (*board_length > 0) ){
                if (len != NO_MORE_INFO_FIELD){
                   printf("Additional Custom Mfg. length: 0x%02x\n", len);
                   if ( (size_board > 0) && (size_board < (*board_length)) ){

Places

File ekanalyzer_fix_wrong_type_comparison.patch of Package ipmitool

Places