File checkinstall-ldflags.patch of Package checkinstall

Overview Repositories Revisions Requests Users Attributes Meta

File checkinstall-ldflags.patch of Package checkinstall

Lesson 87: If you write a Makefile by hand, at least do it right.

Example case:
ld -shared -o installwatch.so installwatch.o -ldl -lc
ld: sparc:v9[sparc64] architecture of input file `installwatch.o' is incompatible with sparc[sparc32] output

Well well, where's LDFLAGS... let me add it.

---
 installwatch/Makefile |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: checkinstall-1.6.2/installwatch/Makefile
===================================================================
--- checkinstall-1.6.2.orig/installwatch/Makefile
+++ checkinstall-1.6.2/installwatch/Makefile
@@ -22,10 +22,10 @@ ALL_CFLAGS = $(CFLAGS) $(DEFINES)
 all: installwatch.so
 
 installwatch.so: installwatch.o
-	ld -shared -o installwatch.so installwatch.o -ldl -lc
+	$(LD) $(LDFLAGS) -shared -o installwatch.so installwatch.o -ldl -lc
 
 installwatch.o: installwatch.c localdecls.h
-	gcc $(ALL_CFLAGS) -c installwatch.c
+	$(CC) $(ALL_CFLAGS) -c installwatch.c
 
 localdecls.h: create-localdecls
 	./create-localdecls
@@ -52,7 +52,7 @@ tarball: clean
 	tar -czvC .. -f ../installwatch-$(VERSION).tar.gz installwatch-$(VERSION)
 
 test: install
-	gcc $(ALL_CFLAGS) -o test-installwatch test-installwatch.c $(LIBS)
+	$(CC) $(ALL_CFLAGS) $(LDFLAGS) -o test-installwatch test-installwatch.c $(LIBS)
 	$(DESTDIR)$(PREFIX)/bin/installwatch ./test-installwatch

Places

File checkinstall-ldflags.patch of Package checkinstall

Places