File chromium-vpx-aarch64.patch of Package chromium

Overview Repositories Revisions Requests Users Attributes Meta

File chromium-vpx-aarch64.patch of Package chromium (Revision dd23725b4d3495783c8a068157f11ca3)

Currently displaying revision dd23725b4d3495783c8a068157f11ca3 , Show latest

From bc30e6e39c8bde9a31e1c314e6d1003ff47f2f7f Mon Sep 17 00:00:00 2001
From: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Fri, 13 Jul 2018 14:29:09 +0200
Subject: [PATCH] vpx_sum_squares_2d_i16_neon(): Make |s2| a uint64x1_t.

=> PATCH EDITED BY GUILLAUME TO MATCH CHROMIUM PATH

This fixes the build with at least GCC 7.3, where it was previously failing
with:

sum_squares_neon.c: In function 'vpx_sum_squares_2d_i16_neon':
sum_squares_neon.c: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts
     s2 = vpaddl_u32(s1);
     ^~
sum_squares_neon.c: incompatible types when assigning to type 'int64x1_t' from type 'uint64x1_t'
     s2 = vpaddl_u32(s1);
        ^
sum_squares_neon.c: incompatible types when assigning to type 'int64x1_t' from type 'uint64x1_t'
     s2 = vadd_u64(vget_low_u64(s1), vget_high_u64(s1));
        ^
sum_squares_neon.c: incompatible type for argument 1 of 'vget_lane_u64'
   return vget_lane_u64(s2, 0);
                        ^~

The generated assembly was verified to remain identical with both GCC and
LLVM.

Bug: chromium:819249
Change-Id: I2778428ee1fee0a674d0d4910347c2a717de21ac
---
 vpx_dsp/arm/sum_squares_neon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/third_party/libvpx/source/libvpx/vpx_dsp/arm/sum_squares_neon.c b/third_party/libvpx/source/libvpx/vpx_dsp/arm/sum_squares_neon.c
index 8942ba83bc..cfefad9938 100644
--- a/third_party/libvpx/source/libvpx/vpx_dsp/arm/sum_squares_neon.c
+++ b/third_party/libvpx/source/libvpx/vpx_dsp/arm/sum_squares_neon.c
@@ -14,7 +14,7 @@
 #include "./vpx_dsp_rtcd.h"
 
 uint64_t vpx_sum_squares_2d_i16_neon(const int16_t *src, int stride, int size) {
-  int64x1_t s2;
+  uint64x1_t s2;
 
   if (size == 4) {
     int16x4_t s[4];

Places

File chromium-vpx-aarch64.patch of Package chromium (Revision dd23725b4d3495783c8a068157f11ca3)

Places