File 0002-Do-not-show-compiler-comments.patch of Package libqt5-qtwebengine

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-Do-not-show-compiler-comments.patch of Package libqt5-qtwebengine

From: Antonio Larrosa <alarrosa@suse.com>
Subject: Add -Wno-comments since otherwise there are too many false positives
References: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61638

This is an excerpt of "Update Chromium to 67.0.3396.47" from upstream

diff --git a/src/3rdparty/chromium/build/config/compiler/BUILD.gn b/src/3rdparty/chromium/build/config/compiler/BUILD.gn
index 7888e2f858..fff8488778 100644
--- a/src/3rdparty/chromium/build/config/compiler/BUILD.gn
+++ b/src/3rdparty/chromium/build/config/compiler/BUILD.gn
@@ -1278,6 +1319,12 @@ config("default_warnings") {
       # [1] https://gcc.gnu.org/gcc-6/porting_to.html#this-cannot-be-null
       # [2] https://crbug.com/784492#c13
       cflags += [ "-fno-delete-null-pointer-checks" ]
+
+      # -Wcomment gives too many false positives in the case a
+      # backslash ended comment line is followed by a new line of
+      # comments
+      # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61638
+      cflags += [ "-Wno-comments" ]
     }
   }

Places

File 0002-Do-not-show-compiler-comments.patch of Package libqt5-qtwebengine

Places