File 0002-Fix-use-after-free-in-LanLinkProvider-conn... of Package kdeconnect-kde

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-Fix-use-after-free-in-LanLinkProvider-connectError.patch of Package kdeconnect-kde (Revision 6d09d615b3b726d70e71cb0915eab518)

Currently displaying revision 6d09d615b3b726d70e71cb0915eab518 , Show latest

From 94298af586541820cd6f1b589b5e6414ea7a2759 Mon Sep 17 00:00:00 2001
From: Matthias Gerstner <mgerstner@suse.de>
Date: Thu, 24 Sep 2020 17:03:06 +0200
Subject: [PATCH 2/9] Fix use after free in LanLinkProvider::connectError()

If QSslSocket::connectToHost() hasn't finished running.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
---
 core/backends/lan/lanlinkprovider.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/backends/lan/lanlinkprovider.cpp b/core/backends/lan/lanlinkprovider.cpp
index 0c200a4f..0e83a150 100644
--- a/core/backends/lan/lanlinkprovider.cpp
+++ b/core/backends/lan/lanlinkprovider.cpp
@@ -248,7 +248,7 @@ void LanLinkProvider::connectError(QAbstractSocket::SocketError socketError)
     //The socket we created didn't work, and we didn't manage
     //to create a LanDeviceLink from it, deleting everything.
     delete m_receivedIdentityPackets.take(socket).np;
-    delete socket;
+    socket->deleteLater();
 }
 
 //We received a UDP packet and answered by connecting to them by TCP. This gets called on a successful connection.
-- 
2.28.0

Places

File 0002-Fix-use-after-free-in-LanLinkProvider-connectError.patch of Package kdeconnect-kde (Revision 6d09d615b3b726d70e71cb0915eab518)

Places