File r883856.diff of Package kdepimlibs4
Subject: fix the kio_sieve related klauncher crashes
From: wstephenson@suse.de
Bug:
Patch-upstream: 883856
--- kioslave/sieve/sieve.cpp (revision 883855)
+++ kioslave/sieve/sieve.cpp (revision 883856)
@@ -891,7 +891,10 @@ bool kio_sieveProtocol::saslInteract( vo
if (m_sUser.isEmpty() || m_sPass.isEmpty()) {
if (!openPasswordDialog(ai)) {
- error(ERR_ABORTED, i18n("No authentication details supplied."));
+ // calling error() below is wrong for two reasons:
+ // - ERR_ABORTED is too harsh
+ // - higher layers already call error() and that can't happen twice.
+ //error(ERR_ABORTED, i18n("No authentication details supplied."));
return false;
}
m_sUser = ai.username;
Index: kioslave/sieve/sieve.cpp
===================================================================