File perl-CGI-Simple-CVE-2010-2761.patch of Package perl-CGI-Simple

Overview Repositories Revisions Requests Users Attributes Meta

File perl-CGI-Simple-CVE-2010-2761.patch of Package perl-CGI-Simple (Revision a73022268764e11851ddbe3653582694)

Currently displaying revision a73022268764e11851ddbe3653582694 , Show latest

# fix CVE-2010-2761 - multipart mime boundary
# This patch randomizes the boundary
# for details, please refer to https://bugzilla.novell.com/show_bug.cgi?id=657343
# CGI::Simple is handled separately via https://bugzilla.novell.com/show_bug.cgi?id=657731
#
Index: lib/CGI/Simple.pm
===================================================================
--- lib/CGI/Simple.pm.orig
+++ lib/CGI/Simple.pm
@@ -1105,7 +1105,13 @@ sub multipart_init {
   my ( $self, @p ) = @_;
   use CGI::Simple::Util qw(rearrange);
   my ( $boundary, @other ) = rearrange( ['BOUNDARY'], @p );
-  $boundary = $boundary || '------- =_aaaaaaaaaa0';
+  if ( !$boundary ) {
+    $boundary = '------- =_';
+    my @chrs = ( '0' .. '9', 'A' .. 'Z', 'a' .. 'z' );
+    for ( 1 .. 17 ) {
+      $boundary .= $chrs[ rand( scalar @chrs ) ];
+  	}
+  }
   my $CRLF = $self->crlf;    # get CRLF sequence
   my $warning
    = "WARNING: YOUR BROWSER DOESN'T SUPPORT THIS SERVER-PUSH TECHNOLOGY.";
Index: t/050.simple.t
===================================================================
--- t/050.simple.t.orig
+++ t/050.simple.t
@@ -945,10 +945,10 @@ $q = new CGI::Simple;
 $sv = $q->multipart_init();
 like(
   $sv,
-  qr|Content-Type: multipart/x-mixed-replace;boundary="------- =_aaaaaaaaaa0"|,
+  qr|Content-Type: multipart/x-mixed-replace;boundary="------- =_[a-zA-Z0-9]{17}"|,
   'multipart_init(), 1'
 );
-like( $sv, qr/--------- =_aaaaaaaaaa0$CRLF/, 'multipart_init(), 2' );
+like( $sv, qr/--------- =_[a-zA-Z0-9]{17}$CRLF/, 'multipart_init(), 2' );
 $sv = $q->multipart_init( 'this_is_the_boundary' );
 like( $sv, qr/boundary="this_is_the_boundary"/, 'multipart_init(), 3' );
 $sv = $q->multipart_init( -boundary => 'this_is_another_boundary' );
Index: t/070.standard.t
===================================================================
--- t/070.standard.t.orig
+++ t/070.standard.t
@@ -953,10 +953,10 @@ restore_parameters();
 $sv = multipart_init();
 like(
   $sv,
-  qr|Content-Type: multipart/x-mixed-replace;boundary="------- =_aaaaaaaaaa0"|,
+  qr|Content-Type: multipart/x-mixed-replace;boundary="------- =_[a-zA-Z0-9]{17}"|,
   'multipart_init(), 1'
 );
-like( $sv, qr/--------- =_aaaaaaaaaa0$CRLF/, 'multipart_init(), 2' );
+like( $sv, qr/--------- =_[a-zA-Z0-9]{17}$CRLF/, 'multipart_init(), 2' );
 $sv = multipart_init( 'this_is_the_boundary' );
 like( $sv, qr/boundary="this_is_the_boundary"/, 'multipart_init(), 3' );
 $sv = multipart_init( -boundary => 'this_is_another_boundary' );

Places

File perl-CGI-Simple-CVE-2010-2761.patch of Package perl-CGI-Simple (Revision a73022268764e11851ddbe3653582694)

Places