openSUSE Build Service

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2013-0153-1 of Package xen

ACPI: acpi_table_parse() should return handler's error code

Currently, the error code returned by acpi_table_parse()'s handler
is ignored. This patch will propagate handler's return value to
acpi_table_parse()'s caller.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com>
Committed-by: Jan Beulich <jbeulich@suse.com>
xen-unstable changeset: 26516:32d4516a97f0
xen-unstable date: Tue Feb  5 14:18:18 UTC 2013

diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
index a25d9b2..151bda6 100644
--- a/xen/drivers/acpi/tables.c
+++ b/xen/drivers/acpi/tables.c
@@ -237,7 +237,7 @@ acpi_table_parse_madt(enum acpi_madt_type id,
  * @handler: handler to run
  *
  * Scan the ACPI System Descriptor Table (STD) for a table matching @id,
- * run @handler on it.  Return 0 if table found, return on if not.
+ * run @handler on it.
  */
 int acpi_table_parse(char *id, acpi_table_handler handler)
 {
@@ -252,8 +252,7 @@ int acpi_table_parse(char *id, acpi_table_handler handler)
 		acpi_get_table(id, 0, &table);
 
 	if (table) {
-		handler(table);
-		return 0;
+		return handler(table);
 	} else
 		return 1;
 }

Places

File CVE-2013-0153-1 of Package xen

Places