Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
openSUSE:Evergreen:Maintenance:114
xen.openSUSE_Evergreen_11.4
23020-x86-cpuidle-ordering.patch
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File 23020-x86-cpuidle-ordering.patch of Package xen.openSUSE_Evergreen_11.4
# HG changeset patch # User Liu, Jinsong <jinsong.liu@intel.com> # Date 1299782132 0 # Node ID 22cc047eb146e00667e62ed13f35005f145f20d5 # Parent c8947c24536a0cdc19c30ec3e435d82f85e38c4d x86: Fix cpuidle bug Before invoking C3, bus master disable / flush cache should be the last step; After resume from C3, bus master enable should be the first step; Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> Acked-by: Wei Gang <gang.wei@intel.com> Index: xen-4.0.3-testing/xen/arch/x86/acpi/cpu_idle.c =================================================================== --- xen-4.0.3-testing.orig/xen/arch/x86/acpi/cpu_idle.c +++ xen-4.0.3-testing/xen/arch/x86/acpi/cpu_idle.c @@ -339,6 +339,19 @@ static void acpi_processor_idle(void) case ACPI_STATE_C3: /* + * Before invoking C3, be aware that TSC/APIC timer may be + * stopped by H/W. Without carefully handling of TSC/APIC stop issues, + * deep C state can't work correctly. + */ + /* preparing APIC stop */ + lapic_timer_off(); + + /* Get start time (ticks) */ + t1 = inl(pmtmr_ioport); + /* Trace cpu idle entry */ + TRACE_4D(TRC_PM_IDLE_ENTRY, cx->idx, t1, exp, pred); + + /* * disable bus master * bm_check implies we need ARB_DIS * !bm_check implies we need cache flush @@ -367,20 +380,18 @@ static void acpi_processor_idle(void) ACPI_FLUSH_CPU_CACHE(); } - /* - * Before invoking C3, be aware that TSC/APIC timer may be - * stopped by H/W. Without carefully handling of TSC/APIC stop issues, - * deep C state can't work correctly. - */ - /* preparing APIC stop */ - lapic_timer_off(); - - /* Get start time (ticks) */ - t1 = inl(pmtmr_ioport); - /* Trace cpu idle entry */ - TRACE_4D(TRC_PM_IDLE_ENTRY, cx->idx, t1, exp, pred); /* Invoke C3 */ acpi_idle_do_entry(cx); + + if ( power->flags.bm_check && power->flags.bm_control ) + { + /* Enable bus master arbitration */ + spin_lock(&c3_cpu_status.lock); + acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0); + c3_cpu_status.count--; + spin_unlock(&c3_cpu_status.lock); + } + /* Get end time (ticks) */ t2 = inl(pmtmr_ioport); @@ -391,15 +402,6 @@ static void acpi_processor_idle(void) TRACE_6D(TRC_PM_IDLE_EXIT, cx->idx, t2, irq_traced[0], irq_traced[1], irq_traced[2], irq_traced[3]); - if ( power->flags.bm_check && power->flags.bm_control ) - { - /* Enable bus master arbitration */ - spin_lock(&c3_cpu_status.lock); - if ( c3_cpu_status.count-- == num_online_cpus() ) - acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0); - spin_unlock(&c3_cpu_status.lock); - } - /* Re-enable interrupts */ local_irq_enable(); /* recovering APIC */
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor