File 0063-pcm-route-Remove-bogus-in-snd_config_get_i... of Package alsa

Overview Repositories Revisions Requests Users Attributes Meta

File 0063-pcm-route-Remove-bogus-in-snd_config_get_id-checks.patch of Package alsa (Revision 4755e52f41c1d9a8b16ecd9dce7308ee)

Currently displaying revision 4755e52f41c1d9a8b16ecd9dce7308ee , Show latest

From 03d6b15291e3534afb72c5aa36495a932ef0cc6a Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 8 Sep 2015 21:48:17 +0200
Subject: [PATCH] pcm: route: Remove bogus ! in snd_config_get_id() checks

There are strange "!" added before snd_config_get_id() return value
checks in a couple of places in pcm_route.c.  This essentially makes
the result always positive, making checks bogus.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 src/pcm/pcm_route.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pcm/pcm_route.c b/src/pcm/pcm_route.c
index 2a437e88b93c..646517d2a9d2 100644
--- a/src/pcm/pcm_route.c
+++ b/src/pcm/pcm_route.c
@@ -770,7 +770,7 @@ static int determine_chmap(snd_config_t *tt, snd_pcm_chmap_t **tt_chmap)
 		snd_config_iterator_t j, jnext;
 		snd_config_t *in = snd_config_iterator_entry(i);
 
-		if (!snd_config_get_id(in, &id) < 0)
+		if (snd_config_get_id(in, &id) < 0)
 			continue;
 		if (snd_config_get_type(in) != SND_CONFIG_TYPE_COMPOUND)
 			goto err;
@@ -1070,7 +1070,7 @@ static int _snd_pcm_route_determine_ttable(snd_config_t *tt,
 		snd_config_iterator_t j, jnext;
 		long cchannel;
 		const char *id;
-		if (!snd_config_get_id(in, &id) < 0)
+		if (snd_config_get_id(in, &id) < 0)
 			continue;
 		err = safe_strtol(id, &cchannel);
 		if (err < 0) {
-- 
2.5.3

Places

File 0063-pcm-route-Remove-bogus-in-snd_config_get_id-checks.patch of Package alsa (Revision 4755e52f41c1d9a8b16ecd9dce7308ee)

Places