File 0001-Fix-Bug-388440-scrolling-in-KMail-page-dow... of Package messagelib

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-Bug-388440-scrolling-in-KMail-page-down-only-wor.patch of Package messagelib (Revision 4e90dda9c561bd5a3076b0ed28e508cc)

Currently displaying revision 4e90dda9c561bd5a3076b0ed28e508cc , Show latest

From ddbdf9b33c6279b0a2ff29a7b67b0044762a258d Mon Sep 17 00:00:00 2001
From: Laurent Montel <montel@kde.org>
Date: Tue, 2 Jan 2018 07:00:11 +0100
Subject: [PATCH] Fix Bug 388440 - scrolling in KMail: "page down" only works
 once

FIXED-IN: 5.7.1
BUG: 388440
document.body.scrollTop was deprecated in removed in last webengine
---
 webengineviewer/src/webenginescript.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/webengineviewer/src/webenginescript.cpp b/webengineviewer/src/webenginescript.cpp
index 8a3afd67..81bd315a 100644
--- a/webengineviewer/src/webenginescript.cpp
+++ b/webengineviewer/src/webenginescript.cpp
@@ -125,7 +125,7 @@ QString WebEngineScript::searchElementPosition(const QString &elementStr)
 
 QString WebEngineScript::scrollPercentage(int percent)
 {
-    const QString source = QStringLiteral("var current = document.body.scrollTop;"
+    const QString source = QStringLiteral("var current = document.documentElement.scrollTop;"
                                                "var docElement = document.documentElement;"
                                                "var height = docElement.clientHeight;"
                                                "var newPosition = current + height * %1 /100;"
@@ -180,7 +180,7 @@ QString WebEngineScript::isScrolledToBottom()
     return QStringLiteral("(function() { "
                                "var docElement = document.documentElement;"
                                "var viewportHeight = docElement.clientHeight;"
-                               "var isAtBottom = document.body.scrollTop + viewportHeight >= document.body.scrollHeight;"
+                               "var isAtBottom = document.documentElement.scrollTop + viewportHeight >= document.body.scrollHeight;"
                                "return Boolean(isAtBottom); "
                                "}());");
 }
-- 
2.15.0

Places

File 0001-Fix-Bug-388440-scrolling-in-KMail-page-down-only-wor.patch of Package messagelib (Revision 4e90dda9c561bd5a3076b0ed28e508cc)

Places