File 0001-Disable-KAuth-integration.patch of Package ktexteditor

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Disable-KAuth-integration.patch of Package ktexteditor (Revision d32ddf36600259d4cf1ae03e85837704)

Currently displaying revision d32ddf36600259d4cf1ae03e85837704 , Show latest

From 94f43c59104f54cdc4e50b35ee420035977ea587 Mon Sep 17 00:00:00 2001
From: Fabian Vogt <fabian@ritter-vogt.de>
Date: Thu, 24 Aug 2017 09:32:10 +0200
Subject: [PATCH] Disable KAuth integration

The security team does not want this in openSUSE, as it is an "insane functionality"
and an "abuse of the privileged DBUS functionality." (boo#1033055).
I disagree, but that does not help much.
---
 src/CMakeLists.txt            | 8 --------
 src/buffer/katetextbuffer.cpp | 3 +--
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index a5e60e1a..e2b7cff9 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -361,13 +361,5 @@ ecm_generate_pri_file(BASE_NAME KTextEditor LIB_NAME KF5TextEditor DEPS "KParts"
 install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
 
 
-add_executable(kauth_ktexteditor_helper buffer/katesecuretextbuffer.cpp)
-target_link_libraries(kauth_ktexteditor_helper
-  KF5::Auth
-)
-install(TARGETS kauth_ktexteditor_helper DESTINATION ${KAUTH_HELPER_INSTALL_DIR} )
-kauth_install_helper_files(kauth_ktexteditor_helper org.kde.ktexteditor.katetextbuffer root)
-kauth_install_actions(org.kde.ktexteditor.katetextbuffer buffer/org.kde.ktexteditor.katetextbuffer.actions)
-
 # add part
 add_subdirectory(part)
diff --git a/src/buffer/katetextbuffer.cpp b/src/buffer/katetextbuffer.cpp
index aa5a4555..c0b72d27 100644
--- a/src/buffer/katetextbuffer.cpp
+++ b/src/buffer/katetextbuffer.cpp
@@ -788,7 +787,7 @@ bool TextBuffer::save(const QString &filename)
     bool usingTemporaryBuffer = false;
 
     // open QSaveFile for write
-    if (m_alwaysUseKAuthForSave || !saveFile->open(QIODevice::WriteOnly)) {
+    if (0 && m_alwaysUseKAuthForSave || !saveFile->open(QIODevice::WriteOnly)) {
 
         // if that fails we need more privileges to save this file
         // -> we write to a temporary file and then send its path to KAuth action for privileged save
-- 
2.13.2

Places

File 0001-Disable-KAuth-integration.patch of Package ktexteditor (Revision d32ddf36600259d4cf1ae03e85837704)

Places