File Fix-spurious-uninitialized-variable-warning.patch of Package netcdf

Overview Repositories Revisions Requests Users Attributes Meta

File Fix-spurious-uninitialized-variable-warning.patch of Package netcdf (Revision 5fac95a852705f14bca9c3602ff35dee)

Currently displaying revision 5fac95a852705f14bca9c3602ff35dee , Show latest

From: Egbert Eich <eich@suse.com>
Date: Sat Jul 10 15:05:08 2021 +0200
Subject: Fix spurious uninitialized variable warning
Patch-mainline: Not yet
Git-repo: https://github.com/Unidata/netcdf-c
Git-commit: 7b4bb9bd0f882e658e4a3e512dda73e90e6c8a18
References:

These variables are not really uninitialized when used, however gcc
isn't able to determine this.

Signed-off-by: Egbert Eich <eich@suse.com>
Signed-off-by: Egbert Eich <eich@suse.de>
---
 libdispatch/nctime.c       |  6 +++---
 libhdf5/hdf5internal.c     |  2 +-
 libnczarr/zinternal.c      |  2 +-
 libnczarr/zsync.c          |  4 ++--
 ncgen3/getfill.c           | 10 +++++-----
 ncgen3/load.c              | 10 +++++-----
 nczarr_test/ncdumpchunks.c |  2 +-
 oc2/ocdump.c               |  4 ++--
 8 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/libdispatch/nctime.c b/libdispatch/nctime.c
index e265ba1f..256cea96 100644
--- a/libdispatch/nctime.c
+++ b/libdispatch/nctime.c
@@ -789,8 +789,8 @@ cdComp2Rel(cdCalenType timetype, cdCompTime comptime, char* relunits, double* re
 	CdTime humantime;
 	CdTimeType old_timetype;
 	cdUnitTime unit;
-	double base_etm, etm, delta;
-	long ndel, hoursInYear;
+	double base_etm, etm, delta = 0.; /* GCC */
+	long ndel = 0, hoursInYear;
 
 					     /* Parse the relunits */
 	if(cdParseRelunits(timetype, relunits, &unit, &base_comptime))
@@ -982,7 +982,7 @@ cdRel2Comp(cdCalenType timetype, char* relunits, double reltime, cdCompTime* com
 	cdCompTime base_comptime;
 	cdUnitTime unit, baseunits;
 	double base_etm, result_etm;
-	double delta;
+	double delta = 0.; /* GCC */
 	long idelta;
 
 					     /* Parse the relunits */
diff --git a/libhdf5/hdf5internal.c b/libhdf5/hdf5internal.c
index 7817bed6..dca5bc86 100644
--- a/libhdf5/hdf5internal.c
+++ b/libhdf5/hdf5internal.c
@@ -860,7 +860,7 @@ nc4_hdf5_find_grp_var_att(int ncid, int varid, const char *name, int attnum,
     NC_FILE_INFO_T *my_h5;
     NC_GRP_INFO_T *my_grp;
     NC_VAR_INFO_T *my_var = NULL;
-    NC_ATT_INFO_T *my_att;
+    NC_ATT_INFO_T *my_att = NULL; /* GCC */
     char my_norm_name[NC_MAX_NAME + 1] = "";
     NCindex *attlist = NULL;
     int retval;
diff --git a/libnczarr/zinternal.c b/libnczarr/zinternal.c
index 48673110..24279b8d 100644
--- a/libnczarr/zinternal.c
+++ b/libnczarr/zinternal.c
@@ -554,7 +554,7 @@ ncz_find_grp_var_att(int ncid, int varid, const char *name, int attnum,
     NC_FILE_INFO_T *my_h5;
     NC_GRP_INFO_T *my_grp;
     NC_VAR_INFO_T *my_var = NULL;
-    NC_ATT_INFO_T *my_att;
+    NC_ATT_INFO_T *my_att = NULL; /* GCC */
     char my_norm_name[NC_MAX_NAME + 1] = "";
     NCindex *attlist = NULL;
     int retval;
diff --git a/libnczarr/zsync.c b/libnczarr/zsync.c
index 97db6e0f..d310ffcc 100644
--- a/libnczarr/zsync.c
+++ b/libnczarr/zsync.c
@@ -289,10 +289,10 @@ ncz_sync_var(NC_FILE_INFO_T* file, NC_VAR_INFO_T* var)
     {	/* Add the type name */
 	const char* dtypename;
 	int endianness = var->type_info->endianness;
-	int islittle;
+	int islittle = 0;
 	switch (endianness) {
 	case NC_ENDIAN_LITTLE: islittle = 1; break;
-	case NC_ENDIAN_BIG: islittle = 0; break;
+	case NC_ENDIAN_BIG: break;
 	case NC_ENDIAN_NATIVE: abort(); /* should never happen */
 	}
 	int atomictype = var->type_info->hdr.id;
diff --git a/ncgen3/getfill.c b/ncgen3/getfill.c
index 91c6ae6f..defa0e2a 100644
--- a/ncgen3/getfill.c
+++ b/ncgen3/getfill.c
@@ -51,11 +51,11 @@ nc_fill(
      void *datp,		/* where to start filling */
      union generic fill_val)	/* value to use */
 {
-    char *char_valp;		/* pointers used to accumulate data values */
-    short *short_valp;
-    int *long_valp;
-    float *float_valp;
-    double *double_valp;
+    char *char_valp = NULL;   /* GCC *//* pointers used to accumulate data values */
+    short *short_valp = NULL; /* GCC */
+    int *long_valp = NULL; /* GCC */
+    float *float_valp = NULL; /* GCC */
+    double *double_valp = NULL; /* GCC */
 
     switch (type) {
       case NC_CHAR:
diff --git a/ncgen3/load.c b/ncgen3/load.c
index 98fa9fbe..13fd2d1c 100644
--- a/ncgen3/load.c
+++ b/ncgen3/load.c
@@ -499,11 +499,11 @@ load_netcdf(
     int stat = NC_NOERR;
     size_t start[NC_MAX_VAR_DIMS];
     size_t count[NC_MAX_VAR_DIMS];
-    char *charvalp;
-    short *shortvalp;
-    int *intvalp;
-    float *floatvalp;
-    double *doublevalp;
+    char *charvalp = NULL; /* GCC */
+    short *shortvalp = NULL; /* GCC */
+    int *intvalp = NULL; /* GCC */
+    float *floatvalp = NULL; /* GCC */
+    double *doublevalp = NULL; /* GCC */
 
     /* load values into variable */
 
diff --git a/nczarr_test/ncdumpchunks.c b/nczarr_test/ncdumpchunks.c
index a6fff5fb..71aed604 100755
--- a/nczarr_test/ncdumpchunks.c
+++ b/nczarr_test/ncdumpchunks.c
@@ -293,7 +293,7 @@ dump(Format* format)
     char sindices[64];
 #ifdef H5
     int i;
-    hid_t fileid, grpid, datasetid;
+    hid_t fileid = H5P_DEFAULT, grpid = H5P_DEFAULT, datasetid = H5P_DEFAULT; /* GCC */
     hid_t dxpl_id = H5P_DEFAULT; /*data transfer property list */
     unsigned int filter_mask = 0;
     hsize_t hoffset[NC_MAX_VAR_DIMS];
diff --git a/oc2/ocdump.c b/oc2/ocdump.c
index fa2c32ae..5d67fcbd 100644
--- a/oc2/ocdump.c
+++ b/oc2/ocdump.c
@@ -467,8 +467,8 @@ ocreadfile(FILE* file, off_t datastart, char** memp, size_t* lenp)
 void
 ocdd(OCstate* state, OCnode* root, int xdrencoded, int level)
 {
-    char* mem;
-    size_t len;
+    char* mem = NULL; /* GCC */
+    size_t len = 0; /* GCC */
     if(root->tree->data.file != NULL) {
         if(!ocreadfile(root->tree->data.file,
                        root->tree->data.bod,

Places

File Fix-spurious-uninitialized-variable-warning.patch of Package netcdf (Revision 5fac95a852705f14bca9c3602ff35dee)

Places