File NCD4_dumpbytes-use-correct-swapline-for-object-... of Package netcdf

Overview Repositories Revisions Requests Users Attributes Meta

File NCD4_dumpbytes-use-correct-swapline-for-object-size.patch of Package netcdf (Revision be22d152442f74d611e1df29f1b35ffc)

Currently displaying revision be22d152442f74d611e1df29f1b35ffc , Show latest

From: Egbert Eich <eich@suse.com>
Date: Sat Jul 10 09:08:33 2021 +0200
Subject: NCD4_dumpbytes: use correct swapline for object size
Patch-mainline: Not yet
Git-repo: https://github.com/Unidata/netcdf-c
Git-commit: 33ebc0efab2ba9a305026d80f39836d3bfabeb04
References:

This addresses a type-punning warning in gcc:
gcc11 warns about one of the strict aliasing violations:
d4util.h:44:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   44 |     *((unsigned int*)ip) = u.i; \
      |      ~^~~~~~~~~~~~~~~~~~
d4dump.c:51:13: note: in expansion of macro 'swapinline32'
   51 |             swapinline32(v.u64);
      |             ^~~~~~~~~~~~

Signed-off-by: Egbert Eich <eich@suse.com>
Signed-off-by: Egbert Eich <eich@suse.de>
---
 libdap4/d4dump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libdap4/d4dump.c b/libdap4/d4dump.c
index b2e18931..2121ab99 100644
--- a/libdap4/d4dump.c
+++ b/libdap4/d4dump.c
@@ -48,12 +48,12 @@ NCD4_dumpbytes(size_t size, const void* data0, int swap)
 	if(swap) {
 	    swapinline16(v.u16);
 	    swapinline32(v.u32);
-	    swapinline32(v.u64);
+	    swapinline64(v.u64);
 	    swapinline16(v.i16);
 	    swapinline32(v.i32);
-	    swapinline32(v.i64);
+	    swapinline64(v.i64);
 	    swapinline32(v.f32);
-	    swapinline32(v.f64);
+	    swapinline64(v.f64);
         }
         if(v.s[0] == '\r') strcpy(v.s,"\\r");
         else if(v.s[0] == '\n') strcpy(v.s,"\\n");

Places

File NCD4_dumpbytes-use-correct-swapline-for-object-size.patch of Package netcdf (Revision be22d152442f74d611e1df29f1b35ffc)

Places