File dwarves-dwarf_loader-Ignore-entries-in-a-DW_TAG... of Package dwarves

Overview Repositories Revisions Requests Users Attributes Meta

File dwarves-dwarf_loader-Ignore-entries-in-a-DW_TAG_partial_unit-for-now.patch of Package dwarves (Revision b203e8641be41ec2395fa9365bab074d)

Currently displaying revision b203e8641be41ec2395fa9365bab074d , Show latest

From 8c92fd298101171dc8479acf4af2fdd2fad88c28 Mon Sep 17 00:00:00 2001
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri, 18 Sep 2020 13:53:01 -0300
Subject: [PATCH] dwarf_loader: Ignore entries in a DW_TAG_partial_unit, for
 now

We will have to keep all CUs in memory and do lookups in imported units,
for now, just don't segfault.

Reported-by: Tom de Vries
Bugtracker: https://github.com/acmel/dwarves/issues/10
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 dwarf_loader.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/dwarf_loader.c b/dwarf_loader.c
index b8d7b35..74e0227 100644
--- a/dwarf_loader.c
+++ b/dwarf_loader.c
@@ -2085,7 +2085,19 @@ static int die__process(Dwarf_Die *die, struct cu *cu)
 	Dwarf_Die child;
 	const uint16_t tag = dwarf_tag(die);
 
-	if (tag != DW_TAG_compile_unit && tag != DW_TAG_type_unit && tag != DW_TAG_partial_unit) {
+	if (tag == DW_TAG_partial_unit) {
+		static bool warned;
+
+		if (!warned) {
+			fprintf(stderr, "WARNING: DW_TAG_partial_unit used, some types will not be considered!\n"
+					"         Probably this was optimized using a tool like 'dwz'\n"
+					"         A future version of pahole will take support this.\n");
+			warned = true;
+		}
+		return 0; // so that other units can be processed
+	}
+
+	if (tag != DW_TAG_compile_unit && tag != DW_TAG_type_unit) {
 		fprintf(stderr, "%s: DW_TAG_compile_unit, DW_TAG_type_unit or DW_TAG_partial_unit expected got %s!\n",
 			__FUNCTION__, dwarf_tag_name(tag));
 		return -EINVAL;
-- 
2.28.0

Places

File dwarves-dwarf_loader-Ignore-entries-in-a-DW_TAG_partial_unit-for-now.patch of Package dwarves (Revision b203e8641be41ec2395fa9365bab074d)

Places