File 647dfb0e-x86-missing-unlock-in-microcode_update... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 647dfb0e-x86-missing-unlock-in-microcode_update_helper.patch of Package xen (Revision 5675090901c0ec1ad65b9c484a74a7ef)

Currently displaying revision 5675090901c0ec1ad65b9c484a74a7ef , Show latest

# Commit b35b22acb887f682efe8385b3df165220bc84c86
# Date 2023-06-05 16:11:10 +0100
# Author Alejandro Vallejo <alejandro.vallejo@cloud.com>
# Committer Andrew Cooper <andrew.cooper3@citrix.com>
x86/microcode: Add missing unlock in microcode_update_helper()

microcode_update_helper() may return early while holding
cpu_add_remove_lock, hence preventing any writers from taking it again.

Leave through the `put` label instead so it's properly released.

Fixes: 5ed12565aa32 ("microcode: rendezvous CPUs in NMI handler and load ucode")
Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -596,7 +596,8 @@ static long cf_check microcode_update_he
         printk(XENLOG_WARNING
                "CPU%u is expected to lead ucode loading (but got CPU%u)\n",
                nmi_cpu, cpumask_first(&cpu_online_map));
-        return -EPERM;
+        ret = -EPERM;
+        goto put;
     }
 
     patch = parse_blob(buffer->buffer, buffer->len);

Places

File 647dfb0e-x86-missing-unlock-in-microcode_update_helper.patch of Package xen (Revision 5675090901c0ec1ad65b9c484a74a7ef)

Places