File icu4c-73_c-ICU-22512-Fix-broken-TestHebrewCalen... of Package icu

Overview Repositories Revisions Requests Users Attributes Meta

File icu4c-73_c-ICU-22512-Fix-broken-TestHebrewCalendarInTemporalLeapYear.patch of Package icu (Revision 2f5428170a8a9e338778ca23f6b04a86)

Currently displaying revision 2f5428170a8a9e338778ca23f6b04a86 , Show latest

From b6b3e89231a623441940889b5badd90f74bdce2b Mon Sep 17 00:00:00 2001
From: Frank Tang <ftang@chromium.org>
Date: Mon, 18 Sep 2023 20:20:42 -0700
Subject: [PATCH] ICU-22512 Fix broken TestHebrewCalendarInTemporalLeapYear

Fix broken test mistakenly landed in
https://github.com/unicode-org/icu/pull/2274

Some important steps were missed in the last landing.
---
 icu4c/source/test/intltest/caltest.cpp | 2 ++
 1 file changed, 2 insertions(+)

Index: icu/source/test/intltest/caltest.cpp
===================================================================
--- icu.orig/source/test/intltest/caltest.cpp
+++ icu/source/test/intltest/caltest.cpp
@@ -3998,6 +3998,7 @@ void CalendarTest::TestHebrewCalendarInT
     for (gc.set(startYear, UCAL_JANUARY, 1);
          gc.get(UCAL_YEAR, status) <= stopYear;
          gc.add(UCAL_DATE, incrementDays, status)) {
+        cal->setTime(gc.getTime(status), status);
         if (failure(status, "add/get/set/getTime/setTime incorrect")) return;
 
         int32_t cal_year = cal->get(UCAL_EXTENDED_YEAR, status);
@@ -4006,6 +4007,7 @@ void CalendarTest::TestHebrewCalendarInT
             leapTest->set(UCAL_MONTH, 0);
             leapTest->set(UCAL_DATE, 1);
             // If 10 months after TISHRI is TAMUZ, then it is a leap year.
+            leapTest->add(UCAL_MONTH, 10, status);
             hasLeapMonth = leapTest->get(UCAL_MONTH, status) == icu::HebrewCalendar::TAMUZ;
             yearForHasLeapMonth = cal_year;
         }

Places

File icu4c-73_c-ICU-22512-Fix-broken-TestHebrewCalendarInTemporalLeapYear.patch of Package icu (Revision 2f5428170a8a9e338778ca23f6b04a86)

Places