File 0007-nvme-cli-fix-connecting-failure-due-to-inv... of Package nvme-cli

Overview Repositories Revisions Requests Users Attributes Meta

File 0007-nvme-cli-fix-connecting-failure-due-to-invalid-uuid-format.patch of Package nvme-cli (Revision f1c341fbc5f7db07765a68bb42e3b650)

Currently displaying revision f1c341fbc5f7db07765a68bb42e3b650 , Show latest

From 0832d06cd62d3541489a3b74e6280b6b68522880 Mon Sep 17 00:00:00 2001
From: Guan Junxiong <guanjunxiong@huawei.com>
Date: Thu, 3 Aug 2017 21:38:16 +0800
Subject: [PATCH] nvme-cli: fix connecting failure due to invalid uuid format
 of hostid

When we connect or discover a target with --hostid option via the
/etc/nvme/hostid file, we fails this operation because the hostid
is only 35 not 36 bytes which doesn't pass the uuid checking in the
kernel.The last character is overridden with null bytes because fgets
reads at most one less than sizeof of buffer characters.

Signed-off-by: Guan Junxiong <guanjunxiong@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
 fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fabrics.c b/fabrics.c
index da4e04e..9ed1127 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -463,7 +463,7 @@ static int nvmf_hostnqn_file(void)
 static int nvmf_hostid_file(void)
 {
 	FILE *f;
-	char hostid[NVMF_HOSTID_SIZE];
+	char hostid[NVMF_HOSTID_SIZE + 1];
 	int ret = false;
 
 	f = fopen(PATH_NVMF_HOSTID, "r");

Places

File 0007-nvme-cli-fix-connecting-failure-due-to-invalid-uuid-format.patch of Package nvme-cli (Revision f1c341fbc5f7db07765a68bb42e3b650)

Places