File chromium-non-void-return.patch of Package chromium.8771
Index: chromium-70.0.3538.45/media/gpu/vaapi/vaapi_wrapper.cc
===================================================================
--- chromium-70.0.3538.45.orig/media/gpu/vaapi/vaapi_wrapper.cc
+++ chromium-70.0.3538.45/media/gpu/vaapi/vaapi_wrapper.cc
@@ -405,6 +405,8 @@ static VAEntrypoint GetVaEntryPoint(Vaap
case VaapiWrapper::kCodecModeMax:
NOTREACHED();
return VAEntrypointVLD;
+ default:
+ return 0;
}
}
Index: chromium-70.0.3538.45/cc/input/snap_fling_controller.cc
===================================================================
--- chromium-70.0.3538.45.orig/cc/input/snap_fling_controller.cc
+++ chromium-70.0.3538.45/cc/input/snap_fling_controller.cc
@@ -26,6 +26,8 @@ bool SnapFlingController::FilterEventFor
case GestureScrollType::kEnd: {
return state_ == State::kActive || state_ == State::kFinished;
}
+ default:
+ return false;
}
}
Index: chromium-70.0.3538.45/chrome/browser/ui/webui/discards/discards_ui.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/webui/discards/discards_ui.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/webui/discards/discards_ui.cc
@@ -47,6 +47,8 @@ mojom::LifecycleUnitVisibility GetLifecy
return mojom::LifecycleUnitVisibility::OCCLUDED;
case content::Visibility::VISIBLE:
return mojom::LifecycleUnitVisibility::VISIBLE;
+ default:
+ return mojom::LifecycleUnitVisibility::VISIBLE;
}
#if defined(COMPILER_MSVC)
NOTREACHED();
Index: chromium-70.0.3538.45/components/autofill/core/browser/autofill_manager.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/autofill/core/browser/autofill_manager.cc
+++ chromium-70.0.3538.45/components/autofill/core/browser/autofill_manager.cc
@@ -255,6 +255,7 @@ PopupType AutofillManager::GetPopupType(
default:
NOTREACHED();
+ return PopupType::kUnspecified;
}
}
Index: chromium-70.0.3538.45/components/cast_channel/cast_message_util.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/cast_channel/cast_message_util.cc
+++ chromium-70.0.3538.45/components/cast_channel/cast_message_util.cc
@@ -373,6 +373,8 @@ const char* GetAppAvailabilityResultToSt
return "unavailable";
case GetAppAvailabilityResult::kUnknown:
return "unknown";
+ default:
+ return "unknown";
}
}
Index: chromium-70.0.3538.45/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
+++ chromium-70.0.3538.45/components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
@@ -337,6 +337,8 @@ PageloadMetrics_ConnectionType ProtoConn
return PageloadMetrics_ConnectionType_CONNECTION_NONE;
case net::NetworkChangeNotifier::CONNECTION_BLUETOOTH:
return PageloadMetrics_ConnectionType_CONNECTION_BLUETOOTH;
+ default:
+ return PageloadMetrics_ConnectionType_CONNECTION_UNKNOWN;
}
}
@@ -351,6 +353,8 @@ RequestInfo_Protocol ProtoRequestInfoPro
return RequestInfo_Protocol_QUIC;
case DataReductionProxyData::RequestInfo::Protocol::UNKNOWN:
return RequestInfo_Protocol_UNKNOWN;
+ default:
+ return RequestInfo_Protocol_UNKNOWN;
}
}
Index: chromium-70.0.3538.45/content/browser/cache_storage/cache_storage_quota_client.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/browser/cache_storage/cache_storage_quota_client.cc
+++ chromium-70.0.3538.45/content/browser/cache_storage/cache_storage_quota_client.cc
@@ -98,6 +98,8 @@ storage::QuotaClient::ID CacheStorageQuo
return kServiceWorkerCache;
case CacheStorageOwner::kBackgroundFetch:
return kBackgroundFetch;
+ default:
+ return kBackgroundFetch;
}
}
Index: chromium-70.0.3538.45/media/capture/video/video_capture_device_descriptor.cc
===================================================================
--- chromium-70.0.3538.45.orig/media/capture/video/video_capture_device_descriptor.cc
+++ chromium-70.0.3538.45/media/capture/video/video_capture_device_descriptor.cc
@@ -94,6 +94,8 @@ const char* VideoCaptureDeviceDescriptor
return "Virtual Device";
case VideoCaptureApi::UNKNOWN:
return "Unknown";
+ default:
+ return "Unknown";
}
}
Index: chromium-70.0.3538.45/net/nqe/network_quality_estimator.cc
===================================================================
--- chromium-70.0.3538.45.orig/net/nqe/network_quality_estimator.cc
+++ chromium-70.0.3538.45/net/nqe/network_quality_estimator.cc
@@ -1387,6 +1387,8 @@ base::TimeDelta NetworkQualityEstimator:
case nqe::internal::OBSERVATION_CATEGORY_COUNT:
NOTREACHED();
return base::TimeDelta();
+ default:
+ return base::TimeDelta();
}
}
Index: chromium-70.0.3538.45/services/audio/public/cpp/audio_system_to_service_adapter.cc
===================================================================
--- chromium-70.0.3538.45.orig/services/audio/public/cpp/audio_system_to_service_adapter.cc
+++ chromium-70.0.3538.45/services/audio/public/cpp/audio_system_to_service_adapter.cc
@@ -66,6 +66,8 @@ const char* GetTraceEvent(Action action)
return "AudioSystemToServiceAdapter::GetAssociatedOutputDeviceID";
case kGetInputDeviceInfo:
return "AudioSystemToServiceAdapter::GetInputDeviceInfo";
+ default:
+ return "Unknown";
}
NOTREACHED();
}
Index: chromium-70.0.3538.45/services/network/cross_origin_read_blocking.cc
===================================================================
--- chromium-70.0.3538.45.orig/services/network/cross_origin_read_blocking.cc
+++ chromium-70.0.3538.45/services/network/cross_origin_read_blocking.cc
@@ -782,6 +782,8 @@ bool CrossOriginReadBlocking::ResponseAn
return sniffers_.empty() && !found_blockable_content_;
case kBlock:
return false;
+ default:
+ return true;
}
}
@@ -793,6 +795,8 @@ bool CrossOriginReadBlocking::ResponseAn
return sniffers_.empty() && found_blockable_content_;
case kBlock:
return true;
+ default:
+ return false;
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
@@ -1220,6 +1220,8 @@ AXTextPosition AXLayoutObject::GetTextPo
return kAXTextPositionSubscript;
case EVerticalAlign::kSuper:
return kAXTextPositionSuperscript;
+ default:
+ return AXNodeObject::GetTextPosition();
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/webaudio/audio_param.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/webaudio/audio_param.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/webaudio/audio_param.cc
@@ -144,6 +144,7 @@ String AudioParamHandler::GetParamName()
return custom_param_name_;
default:
NOTREACHED();
+ return "Unknown";
}
}
Index: chromium-70.0.3538.45/ui/accessibility/platform/ax_platform_node_auralinux.cc
===================================================================
--- chromium-70.0.3538.45.orig/ui/accessibility/platform/ax_platform_node_auralinux.cc
+++ chromium-70.0.3538.45/ui/accessibility/platform/ax_platform_node_auralinux.cc
@@ -1417,6 +1417,8 @@ AtkRole AXPlatformNodeAuraLinux::GetAtkR
case ax::mojom::Role::kPresentational:
case ax::mojom::Role::kUnknown:
return ATK_ROLE_REDUNDANT_OBJECT;
+ default:
+ return ATK_ROLE_REDUNDANT_OBJECT;
}
}
Index: chromium-70.0.3538.45/chrome/browser/chrome_browser_main.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/chrome_browser_main.cc
+++ chromium-70.0.3538.45/chrome/browser/chrome_browser_main.cc
@@ -753,6 +753,8 @@ bool WaitUntilMachineLevelUserCloudPolic
case RegisterResult::kQuitDueToFailure:
chrome::AttemptExit();
return false;
+ default:
+ return true;
}
#else
return true;
Index: chromium-70.0.3538.45/components/password_manager/core/browser/browser_save_password_progress_logger.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/password_manager/core/browser/browser_save_password_progress_logger.cc
+++ chromium-70.0.3538.45/components/password_manager/core/browser/browser_save_password_progress_logger.cc
@@ -72,6 +72,8 @@ std::string VoteTypeToString(
return "HTML classifier";
case AutofillUploadContents::Field::FIRST_USE:
return "First use";
+ default:
+ return "No information";
}
}
Index: chromium-70.0.3538.45/components/previews/content/previews_hints.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/previews/content/previews_hints.cc
+++ chromium-70.0.3538.45/components/previews/content/previews_hints.cc
@@ -104,6 +104,8 @@ ConvertProtoOptimizationTypeToPreviewsOp
return PreviewsType::NOSCRIPT;
case optimization_guide::proto::RESOURCE_LOADING:
return PreviewsType::RESOURCE_LOADING_HINTS;
+ default:
+ return base::nullopt;
}
}
Index: chromium-70.0.3538.45/components/previews/core/previews_black_list.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/previews/core/previews_black_list.cc
+++ chromium-70.0.3538.45/components/previews/core/previews_black_list.cc
@@ -33,6 +33,9 @@ PreviewsEligibilityReason BlacklistReaso
return PreviewsEligibilityReason::ALLOWED;
case blacklist::BlacklistReason::kAllowed:
return PreviewsEligibilityReason::ALLOWED;
+ default:
+ NOTREACHED() << "Previews does not support type-base blacklisting";
+ return PreviewsEligibilityReason::ALLOWED;
}
}
Index: chromium-70.0.3538.45/content/browser/frame_host/frame_tree_node.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/browser/frame_host/frame_tree_node.cc
+++ chromium-70.0.3538.45/content/browser/frame_host/frame_tree_node.cc
@@ -624,6 +624,7 @@ bool FrameTreeNode::UpdateUserActivation
return NotifyUserActivation();
}
NOTREACHED() << "Invalid update_type.";
+ return false;
}
void FrameTreeNode::OnSetHasReceivedUserGestureBeforeNavigation(bool value) {
Index: chromium-70.0.3538.45/content/renderer/input/input_event_prediction.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/renderer/input/input_event_prediction.cc
+++ chromium-70.0.3538.45/content/renderer/input/input_event_prediction.cc
@@ -76,6 +76,8 @@ std::unique_ptr<ui::InputPredictor> Inpu
return std::make_unique<ui::LeastSquaresPredictor>();
case PredictorType::kKalman:
return std::make_unique<ui::KalmanPredictor>();
+ default:
+ return std::make_unique<ui::EmptyPredictor>();
}
}
Index: chromium-70.0.3538.45/content/renderer/media/webrtc/peer_connection_tracker.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/renderer/media/webrtc/peer_connection_tracker.cc
+++ chromium-70.0.3538.45/content/renderer/media/webrtc/peer_connection_tracker.cc
@@ -118,6 +118,8 @@ static const char* SerializeDirection(
return "'recvonly'";
case webrtc::RtpTransceiverDirection::kInactive:
return "'inactive'";
+ default:
+ return "'unknown'";
}
}
Index: chromium-70.0.3538.45/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
===================================================================
--- chromium-70.0.3538.45.orig/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
+++ chromium-70.0.3538.45/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
@@ -397,6 +397,8 @@ bool BluetoothRemoteGattCharacteristic::
return hasNotify;
case NotificationType::kIndication:
return hasIndicate;
+ default:
+ return false;
}
}
Index: chromium-70.0.3538.45/media/blink/watch_time_reporter.cc
===================================================================
--- chromium-70.0.3538.45.orig/media/blink/watch_time_reporter.cc
+++ chromium-70.0.3538.45/media/blink/watch_time_reporter.cc
@@ -571,6 +571,8 @@ WatchTimeKey WatchTimeReporter::GetDispl
return DISPLAY_TYPE_KEY(DisplayFullscreen);
case DisplayType::kPictureInPicture:
return DISPLAY_TYPE_KEY(DisplayPictureInPicture);
+ default:
+ return DISPLAY_TYPE_KEY(DisplayInline);
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/core/css/style_environment_variables.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/core/css/style_environment_variables.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/core/css/style_environment_variables.cc
@@ -67,6 +67,7 @@ const AtomicString StyleEnvironmentVaria
}
NOTREACHED();
+ return "unknown";
}
// static
Index: chromium-70.0.3538.45/third_party/blink/renderer/core/html/media/media_controls.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/core/html/media/media_controls.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/core/html/media/media_controls.cc
@@ -36,6 +36,9 @@ AtomicString MediaControls::GetSizingCSS
return kMediaControlsSizingMediumCSSClass;
case MediaControlsSizingClass::kLarge:
return kMediaControlsSizingLargeCSSClass;
+ default:
+ NOTREACHED();
+ return kMediaControlsSizingMediumCSSClass;
}
NOTREACHED();
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc
@@ -53,6 +53,9 @@ String ToCookieListItemSameSite(network:
return "lax";
case network::mojom::CookieSameSite::NO_RESTRICTION:
return "unrestricted";
+ default:
+ NOTREACHED();
+ return "unknown";
}
NOTREACHED();
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
@@ -28,6 +28,8 @@ String TransceiverDirectionToString(
return "recvonly";
case webrtc::RtpTransceiverDirection::kInactive:
return "inactive";
+ default:
+ return "unknown";
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/platform/heap/heap_stats_collector.h
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/platform/heap/heap_stats_collector.h
+++ chromium-70.0.3538.45/third_party/blink/renderer/platform/heap/heap_stats_collector.h
@@ -94,6 +94,8 @@ class PLATFORM_EXPORT ThreadHeapStatsCol
return "BlinkGC.VisitPersistents";
case Id::kVisitStackRoots:
return "BlinkGC.VisitStackRoots";
+ default:
+ return "BlinkGC.Unknown";
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
@@ -675,6 +675,9 @@ PageSchedulerImpl::PageLifecycleStateTra
NOTREACHED();
return base::nullopt;
}
+ default:
+ NOTREACHED();
+ return base::nullopt;
}
}
Index: chromium-70.0.3538.45/ui/base/mojo/clipboard_struct_traits.h
===================================================================
--- chromium-70.0.3538.45.orig/ui/base/mojo/clipboard_struct_traits.h
+++ chromium-70.0.3538.45/ui/base/mojo/clipboard_struct_traits.h
@@ -20,6 +20,9 @@ struct EnumTraits<ui::mojom::ClipboardTy
return ui::mojom::ClipboardType::SELECTION;
case ui::CLIPBOARD_TYPE_DRAG:
return ui::mojom::ClipboardType::DRAG;
+ default:
+ NOTREACHED();
+ return ui::mojom::ClipboardType::SELECTION;
}
}
@@ -34,6 +37,8 @@ struct EnumTraits<ui::mojom::ClipboardTy
case ui::mojom::ClipboardType::DRAG:
*out = ui::CLIPBOARD_TYPE_DRAG;
return true;
+ default:
+ return false;
}
NOTREACHED();
return false;
Index: chromium-70.0.3538.45/ui/views/layout/layout_provider.cc
===================================================================
--- chromium-70.0.3538.45.orig/ui/views/layout/layout_provider.cc
+++ chromium-70.0.3538.45/ui/views/layout/layout_provider.cc
@@ -156,6 +156,8 @@ int LayoutProvider::GetCornerRadiusMetri
return is_touch ? 8 : 4;
case EMPHASIS_MAXIMUM:
return is_touch ? std::min(size.width(), size.height()) / 2 : 4;
+ default:
+ return 0;
}
}
Index: chromium-70.0.3538.45/base/bind_internal.h
===================================================================
--- chromium-70.0.3538.45.orig/base/bind_internal.h
+++ chromium-70.0.3538.45/base/bind_internal.h
@@ -749,6 +749,7 @@ bool QueryCancellationTraitsImpl(BindSta
functor, std::get<indices>(bound_args)...);
}
NOTREACHED();
+ return false;
}
// Relays |base| to corresponding CallbackCancellationTraits<>::Run(). Returns
Index: chromium-70.0.3538.45/base/callback_internal.cc
===================================================================
--- chromium-70.0.3538.45.orig/base/callback_internal.cc
+++ chromium-70.0.3538.45/base/callback_internal.cc
@@ -21,6 +21,7 @@ bool QueryCancellationTraitsForNonCancel
return true;
}
NOTREACHED();
+ return false;
}
} // namespace
Index: chromium-70.0.3538.45/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
+++ chromium-70.0.3538.45/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
@@ -243,6 +243,8 @@ int& MediaStreamCaptureIndicator::WebCon
NOTREACHED();
return video_stream_count_;
}
+ NOTREACHED();
+ return video_stream_count_;
}
MediaStreamCaptureIndicator::MediaStreamCaptureIndicator() {}
Index: chromium-70.0.3538.45/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
+++ chromium-70.0.3538.45/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
@@ -156,6 +156,8 @@ bool IsValidStateChange(LifecycleUnitSta
}
}
}
+ NOTREACHED();
+ return false;
}
StateChangeReason DiscardReasonToStateChangeReason(
@@ -167,6 +169,9 @@ StateChangeReason DiscardReasonToStateCh
return StateChangeReason::BROWSER_INITIATED;
case LifecycleUnitDiscardReason::URGENT:
return StateChangeReason::SYSTEM_MEMORY_PRESSURE;
+ default:
+ NOTREACHED();
+ return StateChangeReason::BROWSER_INITIATED;
}
}
Index: chromium-70.0.3538.45/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
@@ -201,6 +201,7 @@ base::string16 SaveCardBubbleControllerI
case BubbleType::MANAGE_CARDS:
return l10n_util::GetStringUTF16(IDS_AUTOFILL_CARD_SAVED);
case BubbleType::INACTIVE:
+ default:
NOTREACHED();
return base::string16();
}
Index: chromium-70.0.3538.45/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
@@ -100,6 +100,9 @@ PopupItemLayoutType GetLayoutType(int fr
default:
return PopupItemLayoutType::kTrailingIcon;
}
+ default:
+ NOTREACHED();
+ return PopupItemLayoutType::kLeadingIcon;
}
}
@@ -541,6 +544,9 @@ bool AutofillPopupSuggestionView::Should
case ForcedFontWeight::kBold:
*font_weight = gfx::Font::Weight::BOLD;
return true;
+ default:
+ NOTREACHED();
+ return false;
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc
@@ -19,6 +19,7 @@ WTF::String OverscrollBehaviorTypeToStri
return "contain";
default:
NOTREACHED();
+ return "none";
}
}
Index: chromium-70.0.3538.45/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
@@ -42,6 +42,7 @@ scheduling_metrics::ThreadType ConvertBl
case WebThreadType::kTestThread:
return scheduling_metrics::ThreadType::kRendererOtherBlinkThread;
case WebThreadType::kCount:
+ default:
NOTREACHED();
return scheduling_metrics::ThreadType::kCount;
}
Index: chromium-70.0.3538.45/ui/aura/mus/in_flight_change.cc
===================================================================
--- chromium-70.0.3538.45.orig/ui/aura/mus/in_flight_change.cc
+++ chromium-70.0.3538.45/ui/aura/mus/in_flight_change.cc
@@ -57,6 +57,9 @@ std::string ChangeTypeToString(ChangeTyp
return "TRANSFORM";
case ChangeType::VISIBLE:
return "VISIBLE";
+ default:
+ NOTREACHED();
+ return "UNKNOWN";
}
}
Index: chromium-70.0.3538.45/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
@@ -146,6 +146,8 @@ bool LocalCardMigrationDialogView::Accep
case LocalCardMigrationDialogState::kActionRequired:
return true;
}
+ NOTREACHED();
+ return false;
}
bool LocalCardMigrationDialogView::Cancel() {
@@ -158,6 +160,8 @@ bool LocalCardMigrationDialogView::Cance
OnViewCardsButtonClicked();
return true;
}
+ NOTREACHED();
+ return false;
}
void LocalCardMigrationDialogView::OnWidgetClosing(views::Widget* widget) {
@@ -287,6 +291,8 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_TITLE_FIX);
}
+ NOTREACHED();
+ return l10n_util::GetStringUTF16("");
}
base::string16 LocalCardMigrationDialogView::GetDialogInstruction() const {
@@ -303,6 +309,8 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_MESSAGE_FIX);
}
+ NOTREACHED();
+ return l10n_util::GetStringUTF16("");
}
int LocalCardMigrationDialogView::GetHeaderImageId() const {
@@ -319,6 +327,8 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_DONE);
}
+ NOTREACHED();
+ return l10n_util::GetStringUTF16("");
}
base::string16 LocalCardMigrationDialogView::GetCancelButtonLabel() const {
@@ -331,6 +341,8 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_VIEW_CARDS);
}
+ NOTREACHED();
+ return l10n_util::GetStringUTF16("");
}
void LocalCardMigrationDialogView::OnSaveButtonClicked() {
Index: chromium-70.0.3538.45/chrome/browser/ui/views/material_refresh_layout_provider.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/views/material_refresh_layout_provider.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/views/material_refresh_layout_provider.cc
@@ -34,6 +34,7 @@ int MaterialRefreshLayoutProvider::GetCo
const gfx::Size& size) const {
switch (emphasis_metric) {
case views::EMPHASIS_NONE:
+ default:
NOTREACHED();
return 0;
case views::EMPHASIS_LOW:
@@ -50,6 +51,7 @@ int MaterialRefreshLayoutProvider::GetSh
views::EmphasisMetric emphasis_metric) const {
switch (emphasis_metric) {
case views::EMPHASIS_NONE:
+ default:
NOTREACHED();
return 0;
case views::EMPHASIS_LOW:
Index: chromium-70.0.3538.45/chrome/browser/ui/webui/media/media_engagement_ui.cc
===================================================================
--- chromium-70.0.3538.45.orig/chrome/browser/ui/webui/media/media_engagement_ui.cc
+++ chromium-70.0.3538.45/chrome/browser/ui/webui/media/media_engagement_ui.cc
@@ -99,6 +99,8 @@ class MediaEngagementScoreDetailsProvide
case content::AutoplayPolicy::kDocumentUserActivationRequired:
return "document-user-activation-required";
}
+ NOTREACHED();
+ return "unknown-autoplay-policy";
}
const std::string GetPreloadVersion() {
Index: chromium-70.0.3538.45/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc
+++ chromium-70.0.3538.45/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc
@@ -27,6 +27,7 @@ sync_pb::WalletMaskedCreditCard::WalletC
case CreditCard::OK:
return sync_pb::WalletMaskedCreditCard::VALID;
case CreditCard::EXPIRED:
+ default:
return sync_pb::WalletMaskedCreditCard::EXPIRED;
}
}
@@ -37,6 +38,7 @@ CreditCard::ServerStatus ServerToLocalSt
case sync_pb::WalletMaskedCreditCard::VALID:
return CreditCard::OK;
case sync_pb::WalletMaskedCreditCard::EXPIRED:
+ default:
return CreditCard::EXPIRED;
}
}
@@ -81,6 +83,7 @@ const char* CardNetworkFromWalletCardTyp
case sync_pb::WalletMaskedCreditCard::SOLO:
case sync_pb::WalletMaskedCreditCard::SWITCH:
case sync_pb::WalletMaskedCreditCard::UNKNOWN:
+ default:
return kGenericCard;
}
}
@@ -95,6 +98,7 @@ sync_pb::WalletMaskedCreditCard::WalletC
case CreditCard::CARD_TYPE_PREPAID:
return sync_pb::WalletMaskedCreditCard::PREPAID;
case CreditCard::CARD_TYPE_UNKNOWN:
+ default:
return sync_pb::WalletMaskedCreditCard::UNKNOWN_CARD_CLASS;
}
}
@@ -109,6 +113,7 @@ CreditCard::CardType CardTypeFromWalletC
case sync_pb::WalletMaskedCreditCard::PREPAID:
return CreditCard::CARD_TYPE_PREPAID;
case sync_pb::WalletMaskedCreditCard::UNKNOWN_CARD_CLASS:
+ default:
return CreditCard::CARD_TYPE_UNKNOWN;
}
}
@@ -146,6 +151,7 @@ std::string GetClientTagForSpecificsId(
case sync_pb::AutofillWalletSpecifics::CUSTOMER_DATA:
return "customer-" + wallet_data_specifics_id;
case AutofillWalletSpecifics::UNKNOWN:
+ default:
NOTREACHED();
return "";
}
Index: chromium-70.0.3538.45/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
+++ chromium-70.0.3538.45/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
@@ -40,6 +40,7 @@ std::string GetClientTagForSpecificsId(W
case WalletMetadataSpecifics::CARD:
return "card-" + specifics_id;
case WalletMetadataSpecifics::UNKNOWN:
+ default:
NOTREACHED();
return "";
}
Index: chromium-70.0.3538.45/components/policy/core/common/cloud/cloud_policy_util.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/policy/core/common/cloud/cloud_policy_util.cc
+++ chromium-70.0.3538.45/components/policy/core/common/cloud/cloud_policy_util.cc
@@ -161,6 +161,7 @@ std::string GetOSUsername() {
em::Channel ConvertToProtoChannel(version_info::Channel channel) {
switch (channel) {
case version_info::Channel::UNKNOWN:
+ default:
return em::CHANNEL_UNKNOWN;
case version_info::Channel::CANARY:
return em::CHANNEL_CANARY;
Index: chromium-70.0.3538.45/components/policy/core/common/policy_proto_decoders.cc
===================================================================
--- chromium-70.0.3538.45.orig/components/policy/core/common/policy_proto_decoders.cc
+++ chromium-70.0.3538.45/components/policy/core/common/policy_proto_decoders.cc
@@ -41,6 +41,7 @@ bool GetPolicyLevel(const AnyPolicyProto
*level = POLICY_LEVEL_RECOMMENDED;
return true;
case em::PolicyOptions::UNSET:
+ default:
return false;
}
}
Index: chromium-70.0.3538.45/content/browser/background_fetch/background_fetch_job_controller.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/browser/background_fetch/background_fetch_job_controller.cc
+++ chromium-70.0.3538.45/content/browser/background_fetch/background_fetch_job_controller.cc
@@ -172,6 +172,7 @@ BackgroundFetchJobController::MojoFailur
return blink::mojom::BackgroundFetchFailureReason::QUOTA_EXCEEDED;
}
NOTREACHED();
+ return blink::mojom::BackgroundFetchFailureReason::NONE;
}
void BackgroundFetchJobController::Abort(
Index: chromium-70.0.3538.45/content/renderer/media/stream/media_stream_audio_processor_options.cc
===================================================================
--- chromium-70.0.3538.45.orig/content/renderer/media/stream/media_stream_audio_processor_options.cc
+++ chromium-70.0.3538.45/content/renderer/media/stream/media_stream_audio_processor_options.cc
@@ -63,6 +63,7 @@ AudioProcessingProperties::ToAudioProces
[](EchoCancellationType type) -> media::EchoCancellationType {
switch (type) {
case EchoCancellationType::kEchoCancellationDisabled:
+ default:
return media::EchoCancellationType::kDisabled;
case EchoCancellationType::kEchoCancellationAec2:
return media::EchoCancellationType::kAec2;
Index: chromium-70.0.3538.45/gpu/config/gpu_info.cc
===================================================================
--- chromium-70.0.3538.45.orig/gpu/config/gpu_info.cc
+++ chromium-70.0.3538.45/gpu/config/gpu_info.cc
@@ -67,6 +67,7 @@ namespace gpu {
const char* OverlayFormatToString(OverlayFormat format) {
switch (format) {
case OverlayFormat::kBGRA:
+ default:
return "BGRA";
case OverlayFormat::kYUY2:
return "YUY2";
Index: chromium-70.0.3538.45/media/audio/audio_processing.cc
===================================================================
--- chromium-70.0.3538.45.orig/media/audio/audio_processing.cc
+++ chromium-70.0.3538.45/media/audio/audio_processing.cc
@@ -12,6 +12,7 @@ std::string AudioProcessingSettings::ToS
auto agc_to_string = [](AutomaticGainControlType type) -> const char* {
switch (type) {
case AutomaticGainControlType::kDisabled:
+ default:
return "disabled";
case AutomaticGainControlType::kDefault:
return "default";
@@ -25,6 +26,7 @@ std::string AudioProcessingSettings::ToS
auto aec_to_string = [](EchoCancellationType type) -> const char* {
switch (type) {
case EchoCancellationType::kDisabled:
+ default:
return "disabled";
case EchoCancellationType::kAec2:
return "aec2";
@@ -38,6 +40,7 @@ std::string AudioProcessingSettings::ToS
auto ns_to_string = [](NoiseSuppressionType type) -> const char* {
switch (type) {
case NoiseSuppressionType::kDisabled:
+ default:
return "disabled";
case NoiseSuppressionType::kDefault:
return "default";
Index: chromium-70.0.3538.45/services/network/public/cpp/host_resolver_mojom_traits.cc
===================================================================
--- chromium-70.0.3538.45.orig/services/network/public/cpp/host_resolver_mojom_traits.cc
+++ chromium-70.0.3538.45/services/network/public/cpp/host_resolver_mojom_traits.cc
@@ -15,6 +15,7 @@ ResolveHostParameters::DnsQueryType Enum
input) {
switch (input) {
case net::HostResolver::DnsQueryType::UNSPECIFIED:
+ default:
return ResolveHostParameters::DnsQueryType::UNSPECIFIED;
case net::HostResolver::DnsQueryType::A:
return ResolveHostParameters::DnsQueryType::A;
@@ -39,6 +40,8 @@ bool EnumTraits<ResolveHostParameters::D
*output = net::HostResolver::DnsQueryType::AAAA;
return true;
}
+ NOTREACHED();
+ return false;
}
} // namespace mojo
Index: chromium-70.0.3538.45/services/ws/public/cpp/gpu/command_buffer_metrics.cc
===================================================================
--- chromium-70.0.3538.45.orig/services/ws/public/cpp/gpu/command_buffer_metrics.cc
+++ chromium-70.0.3538.45/services/ws/public/cpp/gpu/command_buffer_metrics.cc
@@ -88,6 +88,7 @@ std::string ContextTypeToString(ContextT
case ContextType::MUS_CLIENT:
return "MusClient";
case ContextType::UNKNOWN:
+ default:
return "Unknown";
case ContextType::FOR_TESTING:
return "ForTesting";
Index: chromium-70.0.3538.45/third_party/blink/renderer/core/loader/mixed_content_checker.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/core/loader/mixed_content_checker.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/core/loader/mixed_content_checker.cc
@@ -238,6 +238,7 @@ bool MixedContentChecker::IsMixedContent
const KURL& url) {
switch (settings.GetHttpsState()) {
case HttpsState::kNone:
+ default:
return false;
case HttpsState::kModern:
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/accessibility/ax_position.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/accessibility/ax_position.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/accessibility/ax_position.cc
@@ -711,6 +711,8 @@ const AXObject* AXPosition::FindNeighbor
return nullptr;
}
}
+ NOTREACHED();
+ return nullptr;
}
bool operator==(const AXPosition& a, const AXPosition& b) {
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
@@ -264,6 +264,7 @@ const String BackgroundFetchRegistration
return "pending";
}
NOTREACHED();
+ return "unknown";
}
const String BackgroundFetchRegistration::failureReason() const {
@@ -284,6 +285,7 @@ const String BackgroundFetchRegistration
return "total-download-exceeded";
}
NOTREACHED();
+ return "unknown";
}
void BackgroundFetchRegistration::Dispose() {
Index: chromium-70.0.3538.45/third_party/blink/renderer/modules/storage/cached_storage_area.cc
===================================================================
--- chromium-70.0.3538.45.orig/third_party/blink/renderer/modules/storage/cached_storage_area.cc
+++ chromium-70.0.3538.45/third_party/blink/renderer/modules/storage/cached_storage_area.cc
@@ -625,6 +625,8 @@ Vector<uint8_t> CachedStorageArea::Strin
}
}
NOTREACHED();
+ Vector<uint8_t> result(sizeof(UChar) + 1);
+ return result;
}
} // namespace blink
