File fix-build-with-gcc48.patch of Package kstars

Overview Repositories Revisions Requests Users Attributes Meta

File fix-build-with-gcc48.patch of Package kstars (Revision b5e81374032606b1dd7861af7f91d5c2)

Currently displaying revision b5e81374032606b1dd7861af7f91d5c2 , Show latest

From 8f798a5750e6028a4dfa74a481593e01b055bcf3 Mon Sep 17 00:00:00 2001
From: Wolfgang Bauer <wbauer@tmo.at>
Date: Wed, 24 Jan 2018 19:45:15 +0100
Subject: [PATCH] Fix build with gcc 4.8

When building current kstars with gcc 4.8, the build fails with errors
like this:
error: no matching function for call to
'ProfileWizard::connect(QPointer<QProgressDialog>&, void
(QProgressDialog::*)(),
ProfileWizard::detectStellarMate()::__lambda220)'

See also https://bugreports.qt.io/browse/QTBUG-48988

This patch fixes it, similar as in other applications, e.g.
https://cgit.kde.org/kdevelop.git/commit/?h=5.2&id=6d5bdbba0a04d7180bda1f6bb47acb386575a561

Differential Revision: https://phabricator.kde.org/D10086
---
 kstars/ekos/align/offlineastrometryparser.cpp | 2 +-
 kstars/ekos/profilewizard.cpp                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kstars/ekos/align/offlineastrometryparser.cpp b/kstars/ekos/align/offlineastrometryparser.cpp
index 93e1edc9b..61651da42 100644
--- a/kstars/ekos/align/offlineastrometryparser.cpp
+++ b/kstars/ekos/align/offlineastrometryparser.cpp
@@ -280,7 +280,7 @@ bool OfflineAstrometryParser::startSovler(const QString &filename, const QString
     connect(solver, SIGNAL(readyReadStandardOutput()), this, SLOT(logSolver()));
 
 #if QT_VERSION > QT_VERSION_CHECK(5, 6, 0)
-    connect(solver, &QProcess::errorOccurred, this, [&]() {
+    connect(solver.data(), &QProcess::errorOccurred, this, [&]() {
         align->appendLogText(i18n("Error starting solver: %1", solver->errorString()));
         emit solverFailed();
     });
diff --git a/kstars/ekos/profilewizard.cpp b/kstars/ekos/profilewizard.cpp
index 35fb3121a..85c1537c2 100644
--- a/kstars/ekos/profilewizard.cpp
+++ b/kstars/ekos/profilewizard.cpp
@@ -272,7 +272,7 @@ void ProfileWizard::detectStellarMate()
 
     stellarMateDetectDialog->show();
 
-    connect(stellarMateDetectDialog, &QProgressDialog::canceled, [&]()
+    connect(stellarMateDetectDialog.data(), &QProgressDialog::canceled, [&]()
     {
         qMDNS::getInstance()->disconnect();
     });
-- 
2.13.6

Places

File fix-build-with-gcc48.patch of Package kstars (Revision b5e81374032606b1dd7861af7f91d5c2)

Places