File api-avoid-compiler-Werror-return-type-failures.... of Package tcmu-runner

Overview Repositories Revisions Requests Users Attributes Meta

File api-avoid-compiler-Werror-return-type-failures.patch of Package tcmu-runner

From d5ea2b1b11f638650caed8dae6203bf253ab5bcf Mon Sep 17 00:00:00 2001
From: David Disseldorp <ddiss@suse.de>
Date: Mon, 12 Feb 2018 14:08:44 +0100
Subject: [PATCH] api: avoid compiler -Werror=return-type failures

Seen with gcc-7-2.9:
/usr/bin/cc -Dtcmu_EXPORTS -I/usr/include/libnl3 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/ccan  -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -DNDEBUG -Werror -Wall -Wdeclaration-after-statement -std=c99 -O2 -g -DNDEBUG -fPIC   -o CMakeFiles/tcmu.dir/api.c.o   -c /home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c
[   15s] /home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c: In function 'tcmu_get_lba':
[   15s] /home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c:87:1: error: control reaches end of non-void function [-Werror=return-type]
...

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 api.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/api.c b/api.c
index 78a073e..98a35e1 100644
--- a/api.c
+++ b/api.c
@@ -83,6 +83,7 @@ uint64_t tcmu_get_lba(uint8_t *cdb)
 		return be64toh(*((u_int64_t *)&cdb[2]));
 	default:
 		assert_perror(EINVAL);
+		return 0;	/* not reached */
 	}
 }
 
@@ -99,6 +100,7 @@ uint32_t tcmu_get_xfer_length(uint8_t *cdb)
 		return be32toh(*((u_int32_t *)&cdb[10]));
 	default:
 		assert_perror(EINVAL);
+		return 0;	/* not reached */
 	}
 }
 
-- 
2.13.6

Places

File api-avoid-compiler-Werror-return-type-failures.patch of Package tcmu-runner

Places