File 5b508ce8-VMX-dont-clobber-dr6-while-debug-state... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 5b508ce8-VMX-dont-clobber-dr6-while-debug-state-is-lazy.patch of Package xen (Revision 65d7d674e607f5b6d818cbfbc371ee14)

Currently displaying revision 65d7d674e607f5b6d818cbfbc371ee14 , Show latest

# Commit 3cdac2805692c7accde2f405d81cc0be799aee48
# Date 2018-07-19 14:06:48 +0100
# Author Andrew Cooper <andrew.cooper3@citrix.com>
# Committer Andrew Cooper <andrew.cooper3@citrix.com>
x86/vmx: Don't clobber %dr6 while debugging state is lazy

c/s 4f36452b63 introduced a write to %dr6 in the #DB intercept case, but the
guests debug registers may be lazy at this point, at which point the guests
later attempt to read %dr6 will discard this value and use the older stale
value.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>

--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3721,6 +3721,7 @@ void vmx_vmexit_handler(struct cpu_user_
              */
             __vmread(EXIT_QUALIFICATION, &exit_qualification);
             HVMTRACE_1D(TRAP_DEBUG, exit_qualification);
+            __restore_debug_registers(v);
             write_debugreg(6, exit_qualification | DR_STATUS_RESERVED_ONE);
             if ( !v->domain->debugger_attached )
             {

Places

File 5b508ce8-VMX-dont-clobber-dr6-while-debug-state-is-lazy.patch of Package xen (Revision 65d7d674e607f5b6d818cbfbc371ee14)

Places