File e37bd65f-logging-restrict-sockets-to-mode-0600.... of Package libvirt.14743

Overview Repositories Revisions Requests Users Attributes Meta

File e37bd65f-logging-restrict-sockets-to-mode-0600.patch of Package libvirt.14743

>From 4b6c7969a5174aa87b5dad5caa9d9ca31ecbad87 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
Date: Tue, 30 Apr 2019 17:27:41 +0100
Subject: [PATCH 3/6] logging: restrict sockets to mode 0600
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The virtlogd daemon's only intended client is the libvirtd daemon. As
such it should never allow clients from other user accounts to connect.
The code already enforces this and drops clients from other UIDs, but
we can get earlier (and thus stronger) protection against DoS by setting
the socket permissions to 0600

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/logging/virtlogd-admin.socket.in | 1 +
 src/logging/virtlogd.socket.in       | 1 +
 2 files changed, 2 insertions(+)

Index: libvirt-5.1.0/src/logging/virtlogd-admin.socket.in
===================================================================
--- libvirt-5.1.0.orig/src/logging/virtlogd-admin.socket.in
+++ libvirt-5.1.0/src/logging/virtlogd-admin.socket.in
@@ -5,6 +5,7 @@ Before=libvirtd.service
 [Socket]
 ListenStream=@localstatedir@/run/libvirt/virtlogd-admin-sock
 Service=virtlogd.service
+SocketMode=0600
 
 [Install]
 WantedBy=sockets.target
Index: libvirt-5.1.0/src/logging/virtlogd.socket.in
===================================================================
--- libvirt-5.1.0.orig/src/logging/virtlogd.socket.in
+++ libvirt-5.1.0/src/logging/virtlogd.socket.in
@@ -4,6 +4,7 @@ Before=libvirtd.service
 
 [Socket]
 ListenStream=@localstatedir@/run/libvirt/virtlogd-sock
+SocketMode=0600
 
 [Install]
 WantedBy=sockets.target

Places

File e37bd65f-logging-restrict-sockets-to-mode-0600.patch of Package libvirt.14743

Places