File percona-toolkit-2.2.x-disable-default-version-check.patch of Package percona-toolkit
From: Andreas Stieger <andreas.stieger@gmx.de> Date: Mon, 17 Feb 2014 00:15:35 +0000 Subject: disable automatic version check for all tools References: https://bugzilla.novell.com/show_bug.cgi?id=864194 https://bugs.launchpad.net/percona-toolkit/+bug/1279502 Upstream: no Prevents transmission of version information to an external host in the default configuration. Can be used by owner of a Percona Server (or an attacker who can control this destination for the client) to collect arbitrary MySQL configuration parameters and execute commands (with -v). Now the version check needs to be requested via command line or global/tool specific/user configuration. (--version-check) Note that the doc is parsed into a Perl Getopt::Long spec at runtime. Setting "default: no" does not work, "default: 0" would work. The spec file contains a %check section that tests this. Patching the source was chosen over supplying default configuration files in /etc/percona-toolkit/percona-toolkit.conf because not all tools actually support the version check and would throw warnings. --- bin/pt-archiver | 2 -- bin/pt-config-diff | 2 -- bin/pt-deadlock-logger | 2 -- bin/pt-diskstats | 2 -- bin/pt-duplicate-key-checker | 2 -- bin/pt-find | 2 -- bin/pt-fk-error-logger | 2 -- bin/pt-heartbeat | 2 -- bin/pt-index-usage | 2 -- bin/pt-kill | 2 -- bin/pt-online-schema-change | 2 -- bin/pt-query-digest | 2 -- bin/pt-slave-delay | 2 -- bin/pt-slave-restart | 2 -- bin/pt-table-checksum | 2 -- bin/pt-table-sync | 2 -- bin/pt-upgrade | 2 -- bin/pt-variable-advisor | 2 -- 18 files changed, 36 deletions(-) Index: percona-toolkit-2.2.20/bin/pt-archiver =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-archiver 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-archiver 2016-12-11 14:19:59.000000000 +0100 @@ -7990,8 +7990,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-config-diff =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-config-diff 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-config-diff 2016-12-11 14:19:59.000000000 +0100 @@ -5646,8 +5646,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-deadlock-logger =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-deadlock-logger 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-deadlock-logger 2016-12-11 14:19:59.000000000 +0100 @@ -5432,8 +5432,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-diskstats =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-diskstats 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-diskstats 2016-12-11 14:19:59.000000000 +0100 @@ -5508,8 +5508,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-duplicate-key-checker =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-duplicate-key-checker 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-duplicate-key-checker 2016-12-11 14:19:59.000000000 +0100 @@ -5490,8 +5490,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-find =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-find 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-find 2016-12-11 14:19:59.000000000 +0100 @@ -4484,8 +4484,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-fk-error-logger =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-fk-error-logger 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-fk-error-logger 2016-12-11 14:19:59.000000000 +0100 @@ -4419,8 +4419,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-heartbeat =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-heartbeat 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-heartbeat 2016-12-11 14:19:59.000000000 +0100 @@ -7009,8 +7009,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-index-usage =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-index-usage 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-index-usage 2016-12-11 14:19:59.000000000 +0100 @@ -7420,8 +7420,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-kill =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-kill 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-kill 2016-12-11 14:19:59.000000000 +0100 @@ -7790,8 +7790,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-online-schema-change =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-online-schema-change 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-online-schema-change 2016-12-11 14:19:59.000000000 +0100 @@ -12011,8 +12011,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-query-digest =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-query-digest 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-query-digest 2016-12-11 14:19:59.000000000 +0100 @@ -16393,8 +16393,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-slave-delay =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-slave-delay 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-slave-delay 2016-12-11 14:19:59.000000000 +0100 @@ -4739,8 +4739,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-slave-restart =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-slave-restart 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-slave-restart 2016-12-11 14:19:59.000000000 +0100 @@ -5838,8 +5838,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-table-checksum =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-table-checksum 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-table-checksum 2016-12-11 14:19:59.000000000 +0100 @@ -12758,8 +12758,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-table-sync =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-table-sync 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-table-sync 2016-12-11 14:19:59.000000000 +0100 @@ -12600,8 +12600,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-upgrade =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-upgrade 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-upgrade 2016-12-11 14:19:59.000000000 +0100 @@ -11128,8 +11128,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two Index: percona-toolkit-2.2.20/bin/pt-variable-advisor =================================================================== --- percona-toolkit-2.2.20.orig/bin/pt-variable-advisor 2016-12-06 23:01:51.000000000 +0100 +++ percona-toolkit-2.2.20/bin/pt-variable-advisor 2016-12-11 14:19:59.000000000 +0100 @@ -6009,8 +6009,6 @@ Show version and exit. =item --[no]version-check -default: yes - Check for the latest version of Percona Toolkit, MySQL, and other programs. This is a standard "check for updates automatically" feature, with two
