File 0014-Fix-CVE-2017-7378-Out-of-bounds-read-in-Pd... of Package podofo

Overview Repositories Revisions Requests Users Attributes Meta

File 0014-Fix-CVE-2017-7378-Out-of-bounds-read-in-PdfPainter-ExpandTabs.patch of Package podofo (Revision 4a2a4ab3a9916f93b2c4aaa0d77f380b)

Currently displaying revision 4a2a4ab3a9916f93b2c4aaa0d77f380b , Show latest

Subject: Fix CVE-2017-7378: Out of bounds read in PdfPainter::ExpandTabs
Url: https://sourceforge.net/p/podofo/code/1847/

--- a/podofo/trunk/src/doc/PdfPainter.cpp
+++ b/podofo/trunk/src/doc/PdfPainter.cpp
@@ -1938,16 +1938,27 @@
     const pdf_utf16be cTab     = 0x0900;
     const pdf_utf16be cSpace   = 0x2000;
 
+    if( lStringLen == -1 )
+        lStringLen = rsString.GetCharacterLength();
+
+    if (lStringLen > rsString.GetCharacterLength())
+    {
+        PdfError::DebugMessage( "Requested to expand tabs in string of %" PDF_FORMAT_INT64 " chars, while it has only %" PDF_FORMAT_INT64 "; correcting the value\n",
+            static_cast<pdf_int64>( lStringLen ), static_cast<pdf_int64>( rsString.GetCharacterLength() ) );
+
+        lStringLen = rsString.GetCharacterLength();
+    }
+
     // count the number of tabs in the string
     if( bUnicode ) 
     {
-        for( i=0;i<=lStringLen;i++ )
+        for( i=0;i<lStringLen;i++ )
             if( rsString.GetUnicode()[i] == cTab ) 
                 ++nTabCnt;
     }
     else
     {
-        for( i=0;i<=lStringLen;i++ )
+        for( i=0;i<lStringLen;i++ )
             if( rsString.GetString()[i] == '\t' )
                 ++nTabCnt;
     }

Places

File 0014-Fix-CVE-2017-7378-Out-of-bounds-read-in-PdfPainter-ExpandTabs.patch of Package podofo (Revision 4a2a4ab3a9916f93b2c4aaa0d77f380b)

Places