File 0002-nss_gss_princ_to_ids-and-nss_gss_princ_to_... of Package nfsidmap

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-nss_gss_princ_to_ids-and-nss_gss_princ_to_grouplist-.patch of Package nfsidmap (Revision e07bc2140e375122a416100f3499ab1b)

Currently displaying revision e07bc2140e375122a416100f3499ab1b , Show latest

From ba7daebba65dc4b1adfac9c8c61f373d6c394673 Mon Sep 17 00:00:00 2001
From: Scott Mayhew <smayhew@redhat.com>
Date: Wed, 8 Feb 2017 08:40:38 -0500
Subject: [PATCH] nss_gss_princ_to_ids() and nss_gss_princ_to_grouplist() must
 strip the realm

nss_gss_princ_to_ids() and nss_gss_princ_to_grouplist() were hard-coded
to call nss_getpwnam with the 'dostrip' arg set to 0, which is the
opposite of what they should have had.  Note: there's no point making
the decision to strip or not to strip configurable in these two
functions.  Ideally both of these functions should be taking a
gss_name_t instead of a char * for the principal, calling
gss_localname() on that, and passing the result to nss_getpwnam... but
that would require changes in both rpc.svcgssd and libgssglue (both of
which have been deprecated for a while).

Fixes: 4db1bb1 (libnfsidmap: add options to aid id mapping in multi
domain environments)
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
---
 nss.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/nss.c
+++ b/nss.c
@@ -406,7 +406,7 @@ static int nss_gss_princ_to_ids(char *se
 		return -ENOENT;
 	}
 	/* XXX: this should call something like getgssauthnam instead? */
-	pw = nss_getpwnam(princ, NULL, &err, 0);
+	pw = nss_getpwnam(princ, NULL, &err, 1);
 	if (pw == NULL) {
 		err = -ENOENT;
 		goto out;
@@ -429,7 +429,7 @@ int nss_gss_princ_to_grouplist(char *sec
 		goto out;
 	/* XXX: not quite right?  Need to know default realm? */
 	/* XXX: this should call something like getgssauthnam instead? */
-	pw = nss_getpwnam(princ, NULL, &ret, 0);
+	pw = nss_getpwnam(princ, NULL, &ret, 1);
 	if (pw == NULL) {
 		ret = -ENOENT;
 		goto out;

Places

File 0002-nss_gss_princ_to_ids-and-nss_gss_princ_to_grouplist-.patch of Package nfsidmap (Revision e07bc2140e375122a416100f3499ab1b)

Places