File mozilla-bmo1338655.patch of Package seamonkey

Overview Repositories Revisions Requests Users Attributes Meta

File mozilla-bmo1338655.patch of Package seamonkey

# HG changeset patch
# User Ralph Giles <giles@mozilla.com>
# Date 1486760298 28800
# Node ID acfa7cfcb32ba6941d9665327319085aef8c1de4
# Parent  8208dedaa30512b8fa1eb5d2cf3cf15bace67a05
Bug 1338655 - Don't try to build mp4parse bindings. r=froydnj

We use the cheddar crate to generate a C header file
for our mp4parse_capi wrapper crate. Currently we
do this at code check-in time via update-rust.sh.

Cargo 0.18 and later will try to execute a build.rs
file in the crate source tree regardless of whether
it's specified in Cargo.toml so patching out that
line just results in 'crate cheddar not found'.

This change restores the old behaviour by substituting
a 'build = false' line instead.

We do have syntex vendored, but we don't currently build
it by default, so I prefer this solution to just vendoring
cheddar and generating the header at build time. The syntex
crate is quite large and adds significantly to our compile
time.

MozReview-Commit-ID: InJRRODWAdP

diff --git a/media/libstagefright/binding/mp4parse_capi/Cargo.toml b/media/libstagefright/binding/mp4parse_capi/Cargo.toml
--- a/media/libstagefright/binding/mp4parse_capi/Cargo.toml
+++ b/media/libstagefright/binding/mp4parse_capi/Cargo.toml
@@ -13,14 +13,16 @@ license = "MPL-2.0"
 
 repository = "https://github.com/mozilla/mp4parse-rust"
 
 # Avoid complaints about trying to package test files.
 exclude = [
   "*.mp4",
 ]
 
+build = false
+
 [dependencies]
 "mp4parse" = {version = "0.6.0", path = "../mp4parse"}
 
 # Somewhat heavy-handed, but we want at least -Z force-overflow-checks=on.
 [profile.release]
 debug-assertions = true

Places

File mozilla-bmo1338655.patch of Package seamonkey

Places