File 0002-firewall-core-fw_ifcfg-Quickly-return-if-i... of Package firewalld

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-firewall-core-fw_ifcfg-Quickly-return-if-ifcfg-direc.patch of Package firewalld (Revision 871b942b4342fd86af72e5ba8412808d)

Currently displaying revision 871b942b4342fd86af72e5ba8412808d , Show latest

From 9ed2c18357d45f8ec1f11723a1d98377387c1039 Mon Sep 17 00:00:00 2001
From: Markos Chandras <mchandras@suse.de>
Date: Tue, 31 May 2016 11:14:06 +0100
Subject: [PATCH] firewall: core: fw_ifcfg: Quickly return if ifcfg directory
 does not exist

It's possible for the ifcfg directory to be missing or named differently
so do not try to access it if it does not exist. This avoid warnings
during firewalld start up like the following one:

ERROR: Calling post func <function ifcfg_set_zone_of_interface at
0x7fb2f0d4fc80> (('', 'enp3s0')) failed: [Errno 2] No such file or
directory: '/etc/sysconfig/network-scripts'
---
 src/firewall/core/fw_ifcfg.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/firewall/core/fw_ifcfg.py b/src/firewall/core/fw_ifcfg.py
index 33794a7..0b049a6 100644
--- a/src/firewall/core/fw_ifcfg.py
+++ b/src/firewall/core/fw_ifcfg.py
@@ -32,6 +32,10 @@ from firewall.core.io.ifcfg import ifcfg
 def search_ifcfg_of_interface(interface):
     """search ifcfg file for the interface in config.IFCFGDIR"""
 
+    # Return quickly if config.IFCFGDIR does not exist
+    if not os.path.exists(config.IFCFGDIR):
+        return None
+
     filename = "%s/ifcfg-%s" % (config.IFCFGDIR, interface)
     if os.path.exists(filename):
         ifcfg_file = ifcfg(filename)
-- 
2.8.3

Places

File 0002-firewall-core-fw_ifcfg-Quickly-return-if-ifcfg-direc.patch of Package firewalld (Revision 871b942b4342fd86af72e5ba8412808d)

Places