File iplink-Validate-minimum-tx-rate-is-less-than-ma... of Package iproute2

Overview Repositories Revisions Requests Users Attributes Meta

File iplink-Validate-minimum-tx-rate-is-less-than-maximum.patch of Package iproute2 (Revision 10b09744f30dc355771f1440b56f80da)

Currently displaying revision 10b09744f30dc355771f1440b56f80da , Show latest

From: Gal Pressman <galp@mellanox.com>
Date: Tue, 16 Jan 2018 15:41:58 +0200
Subject: iplink: Validate minimum tx rate is less than maximum tx rate
Patch-mainline: v4.15.0
Git-commit: 04be08e0bd2ed67bbedb787b70d1d73e91322d75
References: bsc#1085669

According to the documentation (man ip-link), the minimum TXRATE should
be always <= Maximum TXRATE, but commit f89a2a05ffa9 ("Add support to
configure SR-IOV VF minimum and maximum Tx rate through ip tool") didn't
enforce it.

Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
Cc: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Michal Kubecek <mkubecek@suse.cz>

---
 ip/iplink.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ip/iplink.c b/ip/iplink.c
index 215c1f515520..fcb288aa5501 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -531,6 +531,14 @@ static int iplink_parse_vf(int vf, int *argcp, char ***argvp,
 			if (tivt.max_tx_rate == -1)
 				tivt.max_tx_rate = tmax;
 		}
+
+		if (tivt.max_tx_rate && tivt.min_tx_rate > tivt.max_tx_rate) {
+			fprintf(stderr,
+				"Invalid min_tx_rate %d - must be <= max_tx_rate %d\n",
+				tivt.min_tx_rate, tivt.max_tx_rate);
+			return -1;
+		}
+
 		addattr_l(&req->n, sizeof(*req), IFLA_VF_RATE, &tivt,
 			  sizeof(tivt));
 	}
-- 
2.16.2

Places

File iplink-Validate-minimum-tx-rate-is-less-than-maximum.patch of Package iproute2 (Revision 10b09744f30dc355771f1440b56f80da)

Places