File 0001-Bug-403552-s390x-Fix-vector-facility-bit-n... of Package valgrind

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Bug-403552-s390x-Fix-vector-facility-bit-number.patch of Package valgrind (Revision 662ca030427396c4fb3d477a7c623be3)

Currently displaying revision 662ca030427396c4fb3d477a7c623be3 , Show latest

From 467c7c4c9665c0f8b41a4416722a027ebc05df2b Mon Sep 17 00:00:00 2001
From: Andreas Arnez <arnez@linux.ibm.com>
Date: Mon, 21 Jan 2019 14:10:00 +0100
Subject: [PATCH] Bug 403552 s390x: Fix vector facility bit number

The wrong bit number was used when checking for the vector facility.  This
can result in a fatal emulation error: "Encountered an instruction that
requires the vector facility.  That facility is not available on this
host."

In many cases the wrong facility bit was usually set as well, hence
nothing bad happened.  But when running Valgrind within a Qemu/KVM guest,
the wrong bit was not (always?) set and the emulation error occurred.

This fix simply corrects the vector facility bit number, changing it from
128 to 129.
---
 NEWS                          | 1 +
 VEX/pub/libvex_s390x_common.h | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Index: valgrind-3.14.0/NEWS
===================================================================
--- valgrind-3.14.0.orig/NEWS
+++ valgrind-3.14.0/NEWS
@@ -175,6 +175,7 @@ where XXXXXX is the bug number as listed
 398028  Assertion `cfsi_fits` failing in simple C program
 398066  s390x: cgijl dep1, 0 reports false unitialised values warning
 402519  POWER 3.0 addex instruction incorrectly implemented
+403552  s390x: wrong facility bit checked for vector facility
 
 n-i-bz  Fix missing workq_ops operations (macOS)
 n-i-bz  fix bug in strspn replacement
Index: valgrind-3.14.0/VEX/pub/libvex_s390x_common.h
===================================================================
--- valgrind-3.14.0.orig/VEX/pub/libvex_s390x_common.h
+++ valgrind-3.14.0/VEX/pub/libvex_s390x_common.h
@@ -103,7 +103,7 @@
 #define S390_FAC_MSA5    57  // message-security-assist 5
 #define S390_FAC_TREXE   73  // transactional execution
 #define S390_FAC_MSA4    77  // message-security-assist 4
-#define S390_FAC_VX      128 // vector facility
+#define S390_FAC_VX      129 // vector facility
 
 
 /*--------------------------------------------------------------*/

Places

File 0001-Bug-403552-s390x-Fix-vector-facility-bit-number.patch of Package valgrind (Revision 662ca030427396c4fb3d477a7c623be3)

Places