File fix-missing-return.patch of Package libqt5-qtwebengine

Overview Repositories Revisions Requests Users Attributes Meta

File fix-missing-return.patch of Package libqt5-qtwebengine (Revision cfa4c9a61e82791823894451a4d0434d)

Currently displaying revision cfa4c9a61e82791823894451a4d0434d , Show latest

From: Antonio Larrosa <alarrosa@suse.com>
Subject: Add a final return statement to a non-void returning function

This return statement is not needed by the code, since it's covered by
an assert that always fails, but obs complains otherwise, making
the package build fail with the following error, so we better add
the missing return.

[ 7406s] I: Program returns random data in a function
[ 7406s] E: libqt5-qtwebengine no-return-in-nonvoid-function ../../3rdparty/chromium/third_party/protobuf/src/google/protobuf/compiler/js/js_generator.cc:489

Index: qtwebengine-opensource-src-5.9.7/src/3rdparty/chromium/third_party/protobuf/src/google/protobuf/compiler/js/js_generator.cc
===================================================================
--- qtwebengine-opensource-src-5.9.7.orig/src/3rdparty/chromium/third_party/protobuf/src/google/protobuf/compiler/js/js_generator.cc
+++ qtwebengine-opensource-src-5.9.7/src/3rdparty/chromium/third_party/protobuf/src/google/protobuf/compiler/js/js_generator.cc
@@ -489,6 +489,7 @@ string JSByteGetterSuffix(BytesMode byte
     default:
       assert(false);
   }
+  return "";
 }
 
 // Returns the field name as a capitalized portion of a getter/setter method

Places

File fix-missing-return.patch of Package libqt5-qtwebengine (Revision cfa4c9a61e82791823894451a4d0434d)

Places