File 0023-efi_loader-Do-not-leak-memory-when-.patch of Package u-boot-highbank

Overview Repositories Revisions Requests Users Attributes Meta

File 0023-efi_loader-Do-not-leak-memory-when-.patch of Package u-boot-highbank (Revision 67a38bb397f760de6b87cdd3a7aaa8e7)

Currently displaying revision 67a38bb397f760de6b87cdd3a7aaa8e7 , Show latest

From 6664cc7a103156a8faee7f94cb1fb86f64776c6c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <stefan.bruens@rwth-aachen.de>
Date: Sat, 1 Oct 2016 23:32:29 +0200
Subject: [PATCH] efi_loader: Do not leak memory when unlinking a mapping
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As soon as a mapping is unlinked from the list, there are no further
references to it, so it should be freed. If it not unlinked,
update the start address and length.

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Reviewed-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 lib/efi_loader/efi_memory.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 742bc90..95aa590 100644
--- a/lib/efi_loader/efi_memory.c
+++ b/lib/efi_loader/efi_memory.c
@@ -116,10 +116,13 @@ static int efi_mem_carve_out(struct efi_mem_list *map,
 		if (map_end == carve_end) {
 			/* Full overlap, just remove map */
 			list_del(&map->link);
+			free(map);
+		} else {
+			map->desc.physical_start = carve_end;
+			map->desc.num_pages = (map_end - carve_end)
+					      >> EFI_PAGE_SHIFT;
 		}
 
-		map_desc->physical_start = carve_end;
-		map_desc->num_pages = (map_end - carve_end) >> EFI_PAGE_SHIFT;
 		return (carve_end - carve_start) >> EFI_PAGE_SHIFT;
 	}

Places

File 0023-efi_loader-Do-not-leak-memory-when-.patch of Package u-boot-highbank (Revision 67a38bb397f760de6b87cdd3a7aaa8e7)

Places