File k3b-fix_extbins_segfault.patch of Package k3b.7604
From ce5d7b139d07a875ea89fe049be852baf23f99f7 Mon Sep 17 00:00:00 2001
From: Leslie Zhai <lesliezhai@llvm.org.cn>
Date: Tue, 28 Nov 2017 10:00:45 +0800
Subject: Fix Memory-leak issue detected by clang analyzer long time ago
CCBUG: 386983
Index: k3b-17.04.2/libk3b/core/k3bexternalbinmanager.cpp
===================================================================
--- k3b-17.04.2.orig/libk3b/core/k3bexternalbinmanager.cpp
+++ k3b-17.04.2/libk3b/core/k3bexternalbinmanager.cpp
@@ -171,6 +171,7 @@ public:
QString name;
QStringList userParameters;
QList<const ExternalBin*> bins;
+ QList<const ExternalBin*> gcBins;
QString defaultBin;
};
@@ -183,7 +184,8 @@ K3b::ExternalProgram::ExternalProgram( c
K3b::ExternalProgram::~ExternalProgram()
{
- qDeleteAll( d->bins );
+ qDeleteAll(d->bins);
+ qDeleteAll(d->gcBins);
delete d;
}
@@ -234,7 +236,7 @@ void K3b::ExternalProgram::addBin( K3b::
void K3b::ExternalProgram::clear()
{
- qDeleteAll(d->bins);
+ d->gcBins << d->bins;
d->bins.clear();
}