File fix-smb-allow-write-access.diff of Package kio-extras5.9862

Overview Repositories Revisions Requests Users Attributes Meta

File fix-smb-allow-write-access.diff of Package kio-extras5.9862

From 550e6915b4a3683206af21651a1335df97d4b3aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20Mal=C3=BD?= <malymi@natur.cuni.cz>
Date: Mon, 10 Jul 2017 19:33:26 +0200
Subject: Allow write access to Samba Shares' root

Summary: kio_smb plugin sets Samba Shares as read-only which results
in incorrect behavior when a user tries to write into a share.

CCBUG: 376344

Reviewers: elvisangelaccio

Differential Revision: https://phabricator.kde.org/D5947
---
 smb/kio_smb_browse.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/smb/kio_smb_browse.cpp b/smb/kio_smb_browse.cpp
index 67e2fa0..1ca90a2 100644
--- a/smb/kio_smb_browse.cpp
+++ b/smb/kio_smb_browse.cpp
@@ -380,10 +380,10 @@ void SMBSlave::listDir( const QUrl& kurl )
                // Set type
                udsentry.insert( KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR );
 
-               // Set permissions
-               udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRUSR | S_IRGRP | S_IROTH | S_IXUSR | S_IXGRP | S_IXOTH));
 
                if (dirp->smbc_type == SMBC_SERVER) {
+                   udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRUSR | S_IXUSR | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH));
+
                    // QString workgroup = m_current_url.host().toUpper();
                    QUrl u("smb:/");
                    u.setHost(dirpName);
@@ -394,7 +394,9 @@ void SMBSlave::listDir( const QUrl& kurl )
                    udsentry.insert(KIO::UDSEntry::UDS_URL, u.url());
 
                    udsentry.insert(KIO::UDSEntry::UDS_MIME_TYPE, QString::fromLatin1("application/x-smb-server"));
-               }
+               } else
+                   udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH));
+
 
                // Call base class to list entry
                listEntry(udsentry);
-- 
cgit v1.1

Places

File fix-smb-allow-write-access.diff of Package kio-extras5.9862

Places