Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
openSUSE:Leap:42.3:Update
mdadm.9932
0112-Detail.c-do-not-skip-first-character-when-...
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File 0112-Detail.c-do-not-skip-first-character-when-calling-xs.patch of Package mdadm.9932
From 02acb5718a68b16def418699c6afcc84223f52c7 Mon Sep 17 00:00:00 2001 From: Coly Li <colyli@suse.de> Date: Tue, 12 Feb 2019 12:43:40 +0800 Subject: [PATCH] Detail.c: do not skip first character when calling xstrdup in Detail() Git-commit: Posted but not upstreamed yet References: bsc#1123814 'Commit b9c9bd9bacaa ("Detail: ensure --export names are acceptable as shell variables")' duplicates mdi->sys_name to sysdev string by, char *sysdev = xstrdup(mdi->sys_name + 1); which skips the first character of mdi->sys_name. Then when running mdadm --detail <md device> --export, the output looks like, MD_DEVICE_ev_sda2_ROLE=1 MD_DEVICE_ev_sda2_DEV=/dev/sda2 The first character of md device (between MD_DEVICE and _ROLE/_DEV) is dropped. The expected output should be, MD_DEVICE_dev_sda2_ROLE=1 MD_DEVICE_dev_sda2_DEV=/dev/sda2 This patch removes the '+ 1' from calling xstrdup() in Detail(), which gets the dropped first character back. (Coly Li: rebased for SLE12-SP3 mdadm) Reported-by: Arvin Schnell <aschnell@suse.com> Fixes: b9c9bd9bacaa ("Detail: ensure --export names are acceptable as 4 shell variables") Signed-off-by: Coly Li <colyli@suse.de> Cc: NeilBrown <neilb@suse.com> --- Detail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: mdadm-4.0/Detail.c =================================================================== --- mdadm-4.0.orig/Detail.c +++ mdadm-4.0/Detail.c @@ -288,7 +288,7 @@ int Detail(char *dev, struct context *c) char *path = map_dev(mdi->disk.major, mdi->disk.minor, 0); - char *sysdev = xstrdup(mdi->sys_name + 1); + char *sysdev = xstrdup(mdi->sys_name); char *cp; for (cp = sysdev; *cp; cp++) if (!isalnum(*cp))
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor