File 2842b103-CVE-2014-1447.patch of Package libvirt.openSUSE_13.1_Update

commit 2842b103b1cd5d0872050a164b758967eb2e4be4
Author: Jiri Denemark <jdenemar@redhat.com>
Date:   Mon Jan 13 15:46:24 2014 +0100

    Really don't crash if a connection closes early
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1047577
    
    When writing commit 173c291, I missed the fact virNetServerClientClose
    unlocks the client object before actually clearing client->sock and thus
    it is possible to hit a window when client->keepalive is NULL while
    client->sock is not NULL. I was thinking client->sock == NULL was a
    better check for a closed connection but apparently we have to go with
    client->keepalive == NULL to actually fix the crash.
    
    Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
    (cherry picked from commit 066c8ef6c18bc1faf8b3e10787b39796a7a06cc0)

Index: libvirt-1.1.2/src/rpc/virnetserverclient.c
===================================================================
--- libvirt-1.1.2.orig/src/rpc/virnetserverclient.c
+++ libvirt-1.1.2/src/rpc/virnetserverclient.c
@@ -1540,7 +1540,7 @@ virNetServerClientStartKeepAlive(virNetS
     /* The connection might have been closed before we got here and thus the
      * keepalive object could have been removed too.
      */
-    if (!client->sock) {
+    if (!client->keepalive) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("connection not open"));
         goto cleanup;
openSUSE Build Service is sponsored by