File u_kdrive-UnregisterFd-Fix-off-by-one.patch of Package xorg-x11-server.openSUSE_13.1_Update

Overview Repositories Revisions Requests Users Attributes Meta

File u_kdrive-UnregisterFd-Fix-off-by-one.patch of Package xorg-x11-server.openSUSE_13.1_Update

From: Egbert Eich <eich@suse.de>
Date: Tue Nov 24 16:10:08 2015 +0100
Subject: [PATCH]kdrive/UnregisterFd: Fix off by one
Patch-mainline: to be upstreamed

References: boo#867483
Signed-off-by: Egbert Eich <eich@suse.com>

The number of FDs has been decremented already, therefore this
number contains the index of the top one that is to me moved down.

Signed-off-by: Egbert Eich <eich@suse.de>
---
 hw/kdrive/src/kinput.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/kdrive/src/kinput.c b/hw/kdrive/src/kinput.c
index 09aae44..b1068bb 100644
--- a/hw/kdrive/src/kinput.c
+++ b/hw/kdrive/src/kinput.c
@@ -221,7 +221,7 @@ KdUnregisterFd(void *closure, int fd, Bool do_close)
             if (do_close)
                 close(kdInputFds[i].fd);
             kdNumInputFds--;
-            for (j = i; j < (kdNumInputFds - 1); j++)
+            for (j = i; j < kdNumInputFds; j++)
                 kdInputFds[j] = kdInputFds[j + 1];
             break;
         }

Places

File u_kdrive-UnregisterFd-Fix-off-by-one.patch of Package xorg-x11-server.openSUSE_13.1_Update

Places