File bsc#1168771-0001-Fix-libcrmcluster-use-uint64_t... of Package pacemaker.16898

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1168771-0001-Fix-libcrmcluster-use-uint64_t-type-for-corosync-rin.patch of Package pacemaker.16898

From 58c8354c0421edf9f14ca08349d3926364363386 Mon Sep 17 00:00:00 2001
From: "Gao,Yan" <ygao@suse.com>
Date: Wed, 8 Apr 2020 17:36:58 +0200
Subject: [PATCH] Fix: libcrmcluster: use uint64_t type for corosync ringid
 (membership id) when updating node state

The reason is not clear yet, but some clusters of users ran into the
situation that corosync somehow bumped the ringid to a huge number like
"4294967300" which is exactly greater than the maximum uint32_t:

```
corosync[...]:   [TOTEM ] A new membership (X.X.X.X:4294967300) was
formed. Members
```

Node state got updated but with a wrong "last_seen" assigned to an
incomplete ringid:
```
pacemaker-controld  [...] info: Quorum retained | membership=4294967300
members=1
pacemaker-controld  [...] notice: Node node1 state is now member |
nodeid=... previous=unknown source=pcmk_quorum_notification
pacemaker-controld  [...] info: Cluster node node1 is now member (was in
unknown state)
```

And it immediately reaped itself from the membership cache because the
wrong "last_seen" of course was not consistent with the ringid:
```
pacemaker-controld  [...] notice: Node node1 state is now lost |
nodeid=... previous=member source=crm_reap_unseen_nodes
pacemaker-controld  [...] info: Cluster node node1 is now lost (was
member)
pacemaker-controld  [...] error: We're not part of the cluster anymore
```

pacemaker-controld would exit, get respawned and again ...

Anyway, corosync ringid is uint64_t type, which should be correctly
passed and kept.
---
 include/crm/cluster/internal.h | 2 +-
 lib/cluster/membership.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/crm/cluster/internal.h b/include/crm/cluster/internal.h
index 73abc99d6..d484b68cf 100644
--- a/include/crm/cluster/internal.h
+++ b/include/crm/cluster/internal.h
@@ -317,7 +317,7 @@ gboolean init_cs_connection_once(crm_cluster_t * cluster);
 crm_node_t *crm_update_peer_proc(const char *source, crm_node_t * peer,
                                  uint32_t flag, const char *status);
 crm_node_t *crm_update_peer_state(const char *source, crm_node_t * node,
-                                  const char *state, int membership);
+                                  const char *state, uint64_t membership);
 
 void crm_update_peer_uname(crm_node_t *node, const char *uname);
 void crm_update_peer_expected(const char *source, crm_node_t * node, const char *expected);
diff --git a/lib/cluster/membership.c b/lib/cluster/membership.c
index 6bd8c889c..e413f60f0 100644
--- a/lib/cluster/membership.c
+++ b/lib/cluster/membership.c
@@ -895,7 +895,7 @@ crm_update_peer_expected(const char *source, crm_node_t * node, const char *expe
  *       within a peer cache iteration if the iterator is supplied.
  */
 static crm_node_t *
-crm_update_peer_state_iter(const char *source, crm_node_t * node, const char *state, int membership, GHashTableIter *iter)
+crm_update_peer_state_iter(const char *source, crm_node_t * node, const char *state, uint64_t membership, GHashTableIter *iter)
 {
     gboolean is_member;
 
@@ -962,7 +962,7 @@ crm_update_peer_state_iter(const char *source, crm_node_t * node, const char *st
  *       otherwise reaping could invalidate the iterator.
  */
 crm_node_t *
-crm_update_peer_state(const char *source, crm_node_t * node, const char *state, int membership)
+crm_update_peer_state(const char *source, crm_node_t * node, const char *state, uint64_t membership)
 {
     return crm_update_peer_state_iter(source, node, state, membership, NULL);
 }
-- 
2.16.4

Places

File bsc#1168771-0001-Fix-libcrmcluster-use-uint64_t-type-for-corosync-rin.patch of Package pacemaker.16898

Places