File bsc#1190821-0001-Log-libcrmcommon-drop-unformat... of Package pacemaker

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1190821-0001-Log-libcrmcommon-drop-unformatted-log-message-about-.patch of Package pacemaker (Revision 942bf0ddc48fdb6d4cf976774d487d80)

Currently displaying revision 942bf0ddc48fdb6d4cf976774d487d80 , Show latest

From 825557ebe55038c2fdb87ed26b91a04173a496bd Mon Sep 17 00:00:00 2001
From: Ken Gaillot <kgaillot@redhat.com>
Date: Tue, 10 Nov 2020 11:13:37 -0600
Subject: [PATCH] Log: libcrmcommon: drop unformatted log message about log
 permissions

Drop the initial "Set r/w permissions" message when adding a log file.

Besides not being particularly helpful, it also was sent to the log file before
opening it with libqb (using fprintf() instead), so it did not have the
formatting that all other messages do.
---
 lib/common/logging.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/common/logging.c b/lib/common/logging.c
index 0e6adaf7e..0c665f0df 100644
--- a/lib/common/logging.c
+++ b/lib/common/logging.c
@@ -251,12 +251,6 @@ crm_add_logfile(const char *filename)
             if (rc < 0) {
                 crm_warn("Cannot change the mode of %s to %o", filename, filemode);
             }
-
-            fprintf(logfile, "Set r/w permissions for uid=%d, gid=%d on %s\n",
-                    pcmk_uid, pcmk_gid, filename);
-            if (fflush(logfile) < 0 || fsync(logfd) < 0) {
-                crm_err("Couldn't write out logfile: %s", filename);
-            }
         }
     }
 
-- 
2.31.1

Places

File bsc#1190821-0001-Log-libcrmcommon-drop-unformatted-log-message-about-.patch of Package pacemaker (Revision 942bf0ddc48fdb6d4cf976774d487d80)

Places