File lxc-wait-after-eth-del.patch of Package libvirt

Overview Repositories Revisions Requests Users Attributes Meta

File lxc-wait-after-eth-del.patch of Package libvirt (Revision 8ba47c16c283e1b1117709710069d07a)

Currently displaying revision 8ba47c16c283e1b1117709710069d07a , Show latest

From ed80946e17d50d1e2d3fdec64bd64eb65c83c446 Mon Sep 17 00:00:00 2001
From: Jim Fehlig <jfehlig@suse.com>
Date: Mon, 27 Jun 2022 16:38:18 -0600
Subject: Wait for udev events to be handled after removing veth

From: <cbosdonnat@suse.com>

As per http://www.redhat.com/archives/libvir-list/2013-July/msg01279.html,
wait for udev events to be handled after removing a virtual NIC.
Any udev rule associated to NIC destroy could happen to run with a new
device with the same name that is being created.
---
 src/lxc/lxc_controller.c | 1 +
 src/lxc/lxc_driver.c     | 2 ++
 src/lxc/lxc_process.c    | 1 +
 3 files changed, 4 insertions(+)

Index: libvirt-8.0.0/src/lxc/lxc_controller.c
===================================================================
--- libvirt-8.0.0.orig/src/lxc/lxc_controller.c
+++ libvirt-8.0.0/src/lxc/lxc_controller.c
@@ -2006,6 +2006,7 @@ static int virLXCControllerDeleteInterfa
         if (virNetDevVethDelete(ctrl->veths[i]) < 0)
             ret = -1;
     }
+    virWaitForDevices();
 
     return ret;
 }
Index: libvirt-8.0.0/src/lxc/lxc_driver.c
===================================================================
--- libvirt-8.0.0.orig/src/lxc/lxc_driver.c
+++ libvirt-8.0.0/src/lxc/lxc_driver.c
@@ -3508,6 +3508,7 @@ lxcDomainAttachDeviceNetLive(virLXCDrive
         case VIR_DOMAIN_NET_TYPE_NETWORK:
         case VIR_DOMAIN_NET_TYPE_ETHERNET:
             ignore_value(virNetDevVethDelete(veth));
+            virWaitForDevices();
             break;
 
         case VIR_DOMAIN_NET_TYPE_DIRECT:
@@ -3947,6 +3948,7 @@ lxcDomainDetachDeviceNetLive(virDomainOb
             virDomainAuditNet(vm, detach, NULL, "detach", false);
             goto cleanup;
         }
+        virWaitForDevices();
         break;
 
         /* It'd be nice to support this, but with macvlan
Index: libvirt-8.0.0/src/lxc/lxc_process.c
===================================================================
--- libvirt-8.0.0.orig/src/lxc/lxc_process.c
+++ libvirt-8.0.0/src/lxc/lxc_process.c
@@ -249,6 +249,7 @@ static void virLXCProcessCleanup(virLXCD
                 VIR_WARN("Unable to release network device '%s'", NULLSTR(iface->ifname));
         }
     }
+    virWaitForDevices();
 
     virDomainConfVMNWFilterTeardown(vm);

Places

File lxc-wait-after-eth-del.patch of Package libvirt (Revision 8ba47c16c283e1b1117709710069d07a)

Places