File openssl-crypto-mem.c-factor-out-memory-allocation-failure-reporting.patch of Package openssl-3
From bd1c59739d57ca27162bd582161a5cbddba21999 Mon Sep 17 00:00:00 2001
From: Eugene Syromiatnikov <esyr@openssl.org>
Date: Thu, 17 Jul 2025 03:29:35 +0200
Subject: [PATCH] crypto/mem.c: factor out memory allocation failure reporting
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28059)
Signed-off-by: Lucas Mulling <lucas.mulling@suse.com>
---
crypto/mem.c | 11 ++-----
include/internal/mem_alloc_utils.h | 50 ++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 9 deletions(-)
create mode 100644 include/internal/mem_alloc_utils.h
Index: openssl-3.5.3/crypto/mem.c
===================================================================
--- openssl-3.5.3.orig/crypto/mem.c
+++ openssl-3.5.3/crypto/mem.c
@@ -9,6 +9,7 @@
#include "internal/e_os.h"
#include "internal/cryptlib.h"
+#include "internal/mem_alloc_utils.h"
#include "crypto/cryptlib.h"
#include <stdio.h>
#include <stdlib.h>
@@ -212,15 +213,7 @@ void *CRYPTO_malloc(size_t num, const ch
if (ptr != NULL)
return ptr;
err:
- /*
- * ossl_err_get_state_int() in err.c uses CRYPTO_zalloc(num, NULL, 0) for
- * ERR_STATE allocation. Prevent mem alloc error loop while reporting error.
- */
- if (file != NULL || line != 0) {
- ERR_new();
- ERR_set_debug(file, line, NULL);
- ERR_set_error(ERR_LIB_CRYPTO, ERR_R_MALLOC_FAILURE, NULL);
- }
+ ossl_report_alloc_err(file, line);
return NULL;
}
Index: openssl-3.5.3/include/internal/mem_alloc_utils.h
===================================================================
--- /dev/null
+++ openssl-3.5.3/include/internal/mem_alloc_utils.h
@@ -0,0 +1,50 @@
+/*
+ * Copyright 2025 The OpenSSL Project Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License 2.0 (the "License"). You may not use
+ * this file except in compliance with the License. You can obtain a copy
+ * in the file LICENSE in the source distribution or at
+ * https://www.openssl.org/source/license.html
+ */
+
+/*
+ * Utility overflow checking and reporting functions
+ */
+
+#ifndef OSSL_INTERNAL_CHECK_SIZE_OVERFLOW_H
+# define OSSL_INTERNAL_CHECK_SIZE_OVERFLOW_H
+
+# include "internal/common.h"
+
+# include <openssl/cryptoerr.h>
+# include <openssl/err.h>
+
+/*
+ * A helper routine to report memory allocation errors.
+ * Similar to the ERR_raise() macro, but accepts explicit file/line arguments,
+ * pre-defines the library to ERR_LIB_CRYPTO, and avoids emitting an error
+ * if both file set to NULL and line set to 0.
+ */
+static ossl_inline ossl_unused void
+ossl_report_alloc_err_ex(const char * const file, const int line,
+ const int reason)
+{
+ /*
+ * ossl_err_get_state_int() in err.c uses CRYPTO_zalloc(num, NULL, 0) for
+ * ERR_STATE allocation. Prevent mem alloc error loop while reporting error.
+ */
+ if (file != NULL || line != 0) {
+ ERR_new();
+ ERR_set_debug(file, line, NULL);
+ ERR_set_error(ERR_LIB_CRYPTO, reason, NULL);
+ }
+}
+
+/* Report a memory allocation failure. */
+static inline void
+ossl_report_alloc_err(const char * const file, const int line)
+{
+ ossl_report_alloc_err_ex(file, line, ERR_R_MALLOC_FAILURE);
+}
+
+#endif /* OSSL_INTERNAL_CHECK_SIZE_OVERFLOW_H */