This request is superseded by
request 658011
(Show diff)
You're not reviewing the full diff of
request 657986
, but the diff to the superseded
request 649132
(Show full diff)
Overview
Request 657986 superseded
No description set
- Created by hellcp
- In state superseded
- Supersedes 649132
- Superseded by 658011
- Open review for opensuse-review-team
- Open review for openSUSE:Factory:Staging:M
Loading...
author
source maintainer
Please include with YaST Sidebar stuff (staging:M)
Login required, please
login
in order to comment
Request History
hellcp created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot set openSUSE:Factory:Staging:M as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:M"
staging-bot accepted review
Picked openSUSE:Factory:Staging:M
repo-checker accepted review
cycle and install check passed
dimstar_suse superseded request
superseded by 658011
This seems/feels like you should Require: google-opensans-fonts - to get the right font as a dependency (on the yast wizard branding, if I got this right)
Probably also adobe-sourcesanspro-fonts
Of course one can argue that the fonts are not a hard dependency to the branding, as they are changable by the user - but imho still the best thing to do