I'm adding here the collected feedback from the private discussions on how to move this forward:
making sure this doesn't break rescue boots etc (although I'm assuming/hoping this is already tested/verified before submission)
decent commit message/changelog, as anyone who will be looking at this change (we have customers and users that routinely scrutinize the changelogs), will have no idea what this is about, and why this is being done.
the way this change was done (via the rpm specfile) may be problematic. Without looking at the diff and knowing what it is trying to achieve, it is really not obvious why /sbin is being linked to /usr/sbin and later the symlink is removed, for anyone that may have to understand this/work with the package in the future. It is also not clear if this trick could break something else down the line if anything changes in the package.
the proper way to do this cleanly is to provide a patch that changes any affected makefiles. This will make the change explicit and prevent any potential breakage in the future. The patch can be also easily upstreamed (which it should, before it's submitted to Factory).
@ailiopoulos, @jankara, @mcgrof: review reminder
I'm adding here the collected feedback from the private discussions on how to move this forward:
making sure this doesn't break rescue boots etc (although I'm assuming/hoping this is already tested/verified before submission)
decent commit message/changelog, as anyone who will be looking at this change (we have customers and users that routinely scrutinize the changelogs), will have no idea what this is about, and why this is being done.
the way this change was done (via the rpm specfile) may be problematic. Without looking at the diff and knowing what it is trying to achieve, it is really not obvious why /sbin is being linked to /usr/sbin and later the symlink is removed, for anyone that may have to understand this/work with the package in the future. It is also not clear if this trick could break something else down the line if anything changes in the package.
the proper way to do this cleanly is to provide a patch that changes any affected makefiles. This will make the change explicit and prevent any potential breakage in the future. The patch can be also easily upstreamed (which it should, before it's submitted to Factory).