Yeah, unfortunately this is broken since PHP 8.4.10 :-(

The following was introduced in PHP 8.4.10 to prepare for the removal of tidyOptIsReadOnly which was deprecated in 2017:

  PHP_CHECK_LIBRARY([$TIDY_LIB_NAME], [tidyOptGetCategory],
    [AC_DEFINE([HAVE_TIDYOPTGETCATEGORY], [1],
      [Define to 1 if Tidy library has the 'tidyOptGetCategory' function.])],
    [],
    [-L$TIDY_LIBDIR])

The problem with this, is that tidyOptGetCategory was introduced in libtidy 5.4.0, but unfortunately TidyInternalCategory in libtidy 5.6.0. So the following will break with the former library:

#if defined(HAVE_TIDYOPTGETCATEGORY)
    if (tidyOptGetCategory(opt) == TidyInternalCategory) {
#else
    if (tidyOptIsReadOnly(opt)) {
#endif

Unfortunately, we have quite a number of distributions where libtidy 5.4.0 is used and consequently, PHP 8.4.10+ fails to build on all of those.

@pgajdos: Do you think it makes sense to fix this? This can be fixed rather easily by checking for the presence of TidyInternalCategory instead.

Arjen de Korte (adkorte) - about 1 month ago

maintainer

It looks like upstream is working on this, so lets wait for the upstream fix [gh#php/php-src#19021]

---

Miuku . (Miuku) - about 1 month ago

Thank you Arjen, I was able to locally build a working (cough) PHP 8.4.11 by throwing the entire

if defined(HAVE_TIDYOPTGETCATEGORY) if (tidyOptGetCategory(opt) == TidyInternalCategory) { else endif

into the nearest lake.

This is naturally not the right way to do things but I was a bit under pressure to get this working so.. :-)

Let's wait for upstream to get this working properly, thanks for your time :)