drankinatty wrote over 2 years ago

Currently builds locally with rpmbuild -ba, but not here on buildservice. In addition to the Makefile.{am,in} patches above, we will have to patch additional files to look for .svg icons instead of .png. The list to consider is:

Makefile.am:20:self_icon_DATA=yast.png Makefile.in:263:self_icon_DATA = yast.png y2controlcenter.cpp:43: QString iconName( ICON_DIR "/yast.png" ); y2controlcenterview.cpp:63: // show titlebar only if title-bar-gradient.png exists y2controlcenterview.cpp:64: if ( !QPixmap( PIXMAP_DIR "/title-bar-gradient.png" ).isNull() ) y2controlcenterview.cpp:206: QPixmap titleBarGradientPixmap = QPixmap( PIXMAP_DIR "/title-bar-gradient.png" ); y2controlcenterview.cpp:220: QPixmap leftLogo( PIXMAP_DIR "/title-bar-left.png" ); y2controlcenterview.cpp:246: QPixmap rightLogo( PIXMAP_DIR "/title-bar-right.png" ); yastmodules.cpp:55:#define DEFAULT_GROUP_ICON "yast-default-group.png" yastmodules.cpp:251: QRegExp extension( "\.(png|jpg)$", false ); // case insensitive yastmodules.cpp:253: if ( icon.find( extension ) < 0 ) // no .png or .jpg extension? yastmodules.cpp:254: icon += ".png"; // assume .png yastmodules.cpp:326: QRegExp extension( "\.(png|jpg)$", false ); // case insensitive yastmodules.cpp:328: if ( icon.find( extension ) < 0 ) // no .png or .jpg extension? yastmodules.cpp:329: icon += ".png"; // assume .png yastmodules.cpp:540: iconfilename = "default.png";

drankinatty wrote over 2 years ago

Looks like there will need to be a new svg interface written for yast2-control-center-qt3, since Qt3 support says: QImageIO contains a QIODevice object that is used for image data I/O. The programmer can install new image file formats in addition to those that Qt provides.

Qt currently supports the following image file formats: PNG, BMP, XBM, XPM and PNM. It may also support JPEG, MNG and GIF, if specially configured during compilation. The different PNM formats are: PBM (P1 or P4), PGM (P2 or P5), and PPM (P3 or P6).