File 0001-Fix-preview-widget-appearing-to-scale-twic... of Package kscreen5

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-preview-widget-appearing-to-scale-twice.patch of Package kscreen5 (Revision 94a278db935474fb6ea84cf3d75b7465)

Currently displaying revision 94a278db935474fb6ea84cf3d75b7465 , Show latest

From 5c45d27f00b4207d5db347350a81e8ecb6bdb108 Mon Sep 17 00:00:00 2001
From: David Edmundson <kde@davidedmundson.co.uk>
Date: Tue, 24 Jul 2018 21:13:33 +0200
Subject: [PATCH] Fix preview widget appearing to scale twice

Summary:
It worked when I wrote it against integer scaling, it got broken when
fractional support was added, resulting in it rendering at the wrong
size when the host scaling is non integer.

BUG: 388218

Test Plan:
Ran with QT_SCALE_FACTOR=1.5 to simulate the host being at that scale
Opened preview and moved slider
At 1.0 buttons were smaller than the main KCM
At 1.5 buttons looked the same
At 2.0 looked bigger

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14338
---
 kcm/src/previewwidget.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kcm/src/previewwidget.cpp b/kcm/src/previewwidget.cpp
index 3a7341e..8f1a9fd 100644
--- a/kcm/src/previewwidget.cpp
+++ b/kcm/src/previewwidget.cpp
@@ -79,7 +79,7 @@ QPixmap PreviewWidget::updatePixmapCache()
    m_internalPreview ->render(&p);
 
    //render back at whatever the native DPR of the KCM is
-   pixmap.setDevicePixelRatio(devicePixelRatio());
+   pixmap.setDevicePixelRatio(devicePixelRatioF());
 
    return pixmap;
 }
-- 
2.18.0

Places

File 0001-Fix-preview-widget-appearing-to-scale-twice.patch of Package kscreen5 (Revision 94a278db935474fb6ea84cf3d75b7465)

Places