File check_smart-enable_adaptec_raid_controllers.patch of Package monitoring-plugins-smart

Overview Repositories Revisions Requests Users Attributes Meta

File check_smart-enable_adaptec_raid_controllers.patch of Package monitoring-plugins-smart (Revision 1944099e41cc691e066c987308375ddb)

Currently displaying revision 1944099e41cc691e066c987308375ddb , Show latest

--- check_smart.orig	2014-03-28 21:47:41.085702310 +0100
+++ check_smart	2014-03-28 21:50:24.870289428 +0100
@@ -53,7 +53,9 @@
 		exit $ERRORS{'UNKNOWN'};
 	}
 
-	if (-b $opt_d){
+	# This patch enables check_smart to test disks on Adaptec RAID controllers via SCSI generic interface
+	# See: http://www.adaptec.com/weblog/2008/09/26/smartmontools-and-adaptec-raid-controllers/
+	if (-b $opt_d  || (-c $opt_d && $opt_d =~ /\/sg[0-9]+/) ){
 		$device = $opt_d;
 	}
 	else{
@@ -62,7 +64,9 @@
 		exit $ERRORS{'UNKNOWN'};
 	}
 
-	if(grep {$opt_i eq $_} ('ata', 'scsi', 'megaraid')){
+	# This patch enables check_smart to test disks on Adaptec RAID controllers via SAT interface
+	# See: http://www.cyberciti.biz/faq/linux-checking-sas-sata-disks-behind-adaptec-raid-controllers/
+	if(grep {$opt_i eq $_} ('ata', 'scsi', 'megaraid', 'sat')){
 		$interface = $opt_i;
                 if($interface eq 'megaraid'){
                     if(defined($opt_n)){
@@ -107,7 +111,12 @@
 my $line_str = 'SMART overall-health self-assessment test result: '; # ATA SMART line
 my $ok_str = 'PASSED'; # ATA SMART OK string
 
-if ($interface eq 'megaraid'.",".$number or 'scsi'){
+# This patch fix the next if statement to make sure that $number is defined
+if (!$opt_n) {
+	$number = '';
+}
+# This patch fix the next if statement or 'scsi' is always true...
+if ($interface eq 'megaraid'.",".$number or $interface eq 'scsi'){
 	$line_str = 'SMART Health Status: '; # SCSI OR MEGARAID SMART line
 	$ok_str = 'OK'; #SCSI OR MEGARAID SMART OK string
 }
@@ -202,7 +211,8 @@
 my @perfdata = qw//;
 
 # separate metric-gathering and output analysis for ATA vs SCSI SMART output
-if ($interface eq 'ata'){
+# This patch enables check_smart to test disks via SAT interface
+if ($interface eq 'ata' or $interface eq 'sat'){
 	foreach my $line(@output){
 		# get lines that look like this:
 		#    9 Power_On_Minutes        0x0032   241   241   000    Old_age   Always       -       113h+12m
@@ -299,11 +309,11 @@
 
 sub print_help {
 	print_revision($basename,$revision);
-	print "Usage: $basename (--device=<SMART device> --interface=(ata|scsi)|-h|-v) [--debug]\n";
+	print "Usage: $basename (--device=<SMART device> --interface=(ata|sat|scsi|megaraid)|-h|-v) [--debug]\n";
 	print "  --debug: show debugging information\n";
 	print "  -d/--device: a device to be SMART monitored, eg /dev/sda\n";
-	print "  -i/--interface: ata, scsi, megaraid, depending upon the device's interface type\n";
-        print "  -n/--number: where in the argument megaraid, it is the physical disk number within the MegaRAID controller\n";
+	print "  -i/--interface: ata, sat, scsi, megaraid, depending upon the device's interface type\n";
+    print "  -n/--number: where in the argument megaraid, it is the physical disk number within the MegaRAID controller\n";
 	print "  -h/--help: this help\n";
 	print "  -v/--version: Version number\n";
 	support();

Places

File check_smart-enable_adaptec_raid_controllers.patch of Package monitoring-plugins-smart (Revision 1944099e41cc691e066c987308375ddb)

Places