File 0001-Fix-signed-pointer-comparison.patch of Package lcr

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-signed-pointer-comparison.patch of Package lcr

From b962756d9239840c2e8a7fa8c0d409c49659e294 Mon Sep 17 00:00:00 2001
From: Martin Hauke <mardnh@gmx.de>
Date: Fri, 26 Nov 2021 21:56:53 +0100
Subject: [PATCH] Fix signed pointer comparison

mISDN.cpp:56:22: error: ordered comparison of pointer with integer zero ('FILE*' and 'int')
   56 |         if (debug_fp > 0)

mail.c:79:40: error: ordered comparison of pointer with integer zero ('FILE*' and 'int')
   79 |         if ((ph = popen(command, "w")) < 0) {
---
 mISDN.cpp | 2 +-
 mail.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mISDN.cpp b/mISDN.cpp
index d67d0e8..5543f68 100644
--- a/mISDN.cpp
+++ b/mISDN.cpp
@@ -53,7 +53,7 @@ static int my_mISDNlib_debug(const char *file, int line, const char *func, int l
 {
         int ret = 0;
 
-        if (debug_fp > 0)
+        if (debug_fp != 0)
         	ret = vfprintf(debug_fp, fmt, va);
 	return ret;
 }
diff --git a/mail.c b/mail.c
index 0e34b77..19fa521 100644
--- a/mail.c
+++ b/mail.c
@@ -76,7 +76,7 @@ static void *mail_child(void *arg)
 
 	/* open process */
 	SPRINT(command, "%s -f%s %s", SENDMAIL, options.email, email);
-	if ((ph = popen(command, "w")) < 0) {
+	if ((ph = popen(command, "w")) != 0) {
 		PERROR("Cannot send mail using command '%s'\n", command);
 		goto done;
 	}
-- 
2.34.0

Places

File 0001-Fix-signed-pointer-comparison.patch of Package lcr

Places